Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 1129863002: Revert of Adding task runner/ message loop to tests that use IsolateHolder. (Closed)

Created:
5 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Adding task runner/ message loop to tests that use IsolateHolder. (patchset #4 id:60001 of https://codereview.chromium.org/1130433002/) Reason for revert: speculative revert, gin unittests doesn't compile on mac builders anymore Original issue's description: > Adding task runner/ message loop to tests that use IsolateHolder. > > For adding v8 heap memory dump provider, the gin::IsolateHolder needs > to have a task runner at initialization. The tests which don't > initiallize task runner when initialization are changed in this CL to > have either the message loop initializaed earlier or a dummy task > runner. Refer crrev.com/1088683003 for the dump provider. > > BUG=476013 > > Committed: https://crrev.com/54d19441b064ae06604c6a26c3863a091a8bb8bb > Cr-Commit-Position: refs/heads/master@{#328531} TBR=primiano@chromium.org,skyostil@chromium.org,ssid@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=476013 Committed: https://crrev.com/198cfb67ce30c38a2948c80628ce055fcb06a9ef Cr-Commit-Position: refs/heads/master@{#328538}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -65 lines) Patch
M content/test/test_blink_web_unit_test_support.cc View 3 chunks +0 lines, -50 lines 0 comments Download
M gin/modules/module_registry_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M gin/modules/timer_unittest.cc View 6 chunks +11 lines, -11 lines 0 comments Download
M gin/shell_runner_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M gin/test/v8_test.h View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of Adding task runner/ message loop to tests that use IsolateHolder.
5 years, 7 months ago (2015-05-06 15:09:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129863002/1
5 years, 7 months ago (2015-05-06 15:09:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-06 15:10:36 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 15:11:22 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/198cfb67ce30c38a2948c80628ce055fcb06a9ef
Cr-Commit-Position: refs/heads/master@{#328538}

Powered by Google App Engine
This is Rietveld 408576698