gin/test/v8_test.h - Issue 1129863002: Revert of Adding task runner/ message loop to tests that use IsolateHolder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/test/v8_test.h

Issue 1129863002: Revert of Adding task runner/ message loop to tests that use IsolateHolder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gin/test/v8_test.h

diff --git a/gin/test/v8_test.h b/gin/test/v8_test.h

index 592b88904035a0160e7e87a1bb27fcaeb2310a97..e9209ce97921fb17333382092b754b7ebc79970b 100644

--- a/gin/test/v8_test.h

+++ b/gin/test/v8_test.h

@@ -8,7 +8,6 @@

#include "base/basictypes.h"

#include "base/compiler_specific.h"

#include "base/memory/scoped_ptr.h"

-#include "base/message_loop/message_loop.h"

#include "testing/gtest/include/gtest/gtest.h"

#include "v8/include/v8.h"

@@ -27,7 +26,6 @@

void TearDown() override;

protected:

- base::MessageLoop message_loop_;

scoped_ptr<IsolateHolder> instance_;

v8::Persistent<v8::Context> context_;

« no previous file with comments | « gin/shell_runner_unittest.cc ('k') | no next file » | no next file with comments »