Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Issue 1129823003: Add a control benchmark. (Closed)

Created:
5 years, 7 months ago by mtklein_C
Modified:
5 years, 7 months ago
Reviewers:
jcgregorio, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add a control benchmark. I'm thinking of using this in perf with something like: ratio(fill(filter("test=foo")), fill(filter("test=control"))) Does that make sense to you? Not sure that this is really a good control bench on all bots, but I propose we just run it a bit and find out if it needs work. BUG=skia: Committed: https://skia.googlesource.com/skia/+/44d43d8d6e4f9321c9001f269ff433bd06aa81e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
A bench/ControlBench.cpp View 1 chunk +26 lines, -0 lines 0 comments Download
M gyp/bench.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mtklein_C
5 years, 7 months ago (2015-05-06 17:12:29 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129823003/1
5 years, 7 months ago (2015-05-06 17:13:29 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-06 17:19:44 UTC) #6
jcgregorio
lgtm
5 years, 7 months ago (2015-05-06 19:38:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129823003/1
5 years, 7 months ago (2015-05-06 19:41:51 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 19:42:10 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/44d43d8d6e4f9321c9001f269ff433bd06aa81e1

Powered by Google App Engine
This is Rietveld 408576698