Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2165)

Unified Diff: chrome/browser/sync/glue/session_model_associator.h

Issue 11298004: alternate ntp: add "Recent Tabs" submenu to wrench menu (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: addressed scott's comments Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/session_model_associator.h
diff --git a/chrome/browser/sync/glue/session_model_associator.h b/chrome/browser/sync/glue/session_model_associator.h
index 0a61fa12d32162b983e5b5885f1fef6f0805b5ed..2b16534021c2ca616abcb70cbbd0b8347339563a 100644
--- a/chrome/browser/sync/glue/session_model_associator.h
+++ b/chrome/browser/sync/glue/session_model_associator.h
@@ -233,6 +233,24 @@ class SessionModelAssociator
bool GetSyncedFaviconForPageURL(const std::string& url,
std::string* png_favicon) const;
+#if defined(UNIT_TEST)
akalin 2012/11/10 00:08:40 i don't think we should use this ifdef. having di
akalin 2012/11/10 00:08:40 But see comments in unit test file -- I think you
kuan 2012/11/10 19:34:46 i assume u mean i can keep it?
+ // Returns synced session track.
+ SyncedSessionTracker& GetSyncedSessionTrackerForTest() {
akalin 2012/11/10 00:08:40 non-const refs are against style guide. please us
kuan 2012/11/10 19:34:46 function is removed.
+ return synced_session_tracker_;
+ }
+
+ // Wrapper for private PopulateSessionWindowFromSpecifics.
+ static void PopulateSessionWindowFromSpecificsForTest(
+ const std::string& foreign_session_tag,
+ const sync_pb::SessionWindow& window,
+ base::Time mtime,
+ SessionWindow* session_window,
+ SyncedSessionTracker* tracker) {
+ PopulateSessionWindowFromSpecifics(foreign_session_tag, window, mtime,
+ session_window, tracker);
+ }
+#endif // defined(UNIT_TEST)
+
private:
friend class SyncSessionModelAssociatorTest;
FRIEND_TEST_ALL_PREFIXES(ProfileSyncServiceSessionTest, WriteSessionToNode);

Powered by Google App Engine
This is Rietveld 408576698