alternate ntp: add "Recent Tabs" submenu to wrench menu

chrome/browser/sync/glue/session_model_associator.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_GLUE_SESSION_MODEL_ASSOCIATOR_H_
 #define CHROME_BROWSER_SYNC_GLUE_SESSION_MODEL_ASSOCIATOR_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 215 matching lines @@
   void BlockUntilLocalChangeForTest(base::TimeDelta timeout);
 
   // Callback for when the session name has been computed.
   void OnSessionNameInitialized(const std::string& name);
 
   // If a valid favicon for the page at |url| is found, fills |png_favicon| with
   // the png-encoded image and returns true. Else, returns false.
   bool GetSyncedFaviconForPageURL(const std::string& url,
                                   std::string* png_favicon) const;
 
+#if defined(UNIT_TEST)

[akalin, 2012/11/10 00:08:40]

i don't think we should use this ifdef.  having different definitions per
compilation unit is technically undefined behavior, and the inline functions
should get optimized out anyway for non-unit-test executables.

[akalin, 2012/11/10 00:08:40]

But see comments in unit test file -- I think you can do what you want while
just working with the public interface.

[kuan, 2012/11/10 19:34:46]

i assume u mean i can keep it?

+  // Returns synced session track.
+  SyncedSessionTracker& GetSyncedSessionTrackerForTest() {

[akalin, 2012/11/10 00:08:40]

non-const refs are against style guide.  please use a pointer.

[kuan, 2012/11/10 19:34:46]

function is removed.

+    return synced_session_tracker_;
+  }
+
+  // Wrapper for private PopulateSessionWindowFromSpecifics.
+  static void PopulateSessionWindowFromSpecificsForTest(
+      const std::string& foreign_session_tag,
+      const sync_pb::SessionWindow& window,
+      base::Time mtime,
+      SessionWindow* session_window,
+      SyncedSessionTracker* tracker) {
+    PopulateSessionWindowFromSpecifics(foreign_session_tag, window, mtime,
+                                       session_window, tracker);
+  }
+#endif  // defined(UNIT_TEST)
+
  private:
   friend class SyncSessionModelAssociatorTest;
   FRIEND_TEST_ALL_PREFIXES(ProfileSyncServiceSessionTest, WriteSessionToNode);
   FRIEND_TEST_ALL_PREFIXES(ProfileSyncServiceSessionTest,
                            WriteFilledSessionToNode);
   FRIEND_TEST_ALL_PREFIXES(ProfileSyncServiceSessionTest,
                            WriteForeignSessionToNode);
   FRIEND_TEST_ALL_PREFIXES(ProfileSyncServiceSessionTest, TabNodePoolEmpty);
   FRIEND_TEST_ALL_PREFIXES(ProfileSyncServiceSessionTest, TabNodePoolNonEmpty);
   FRIEND_TEST_ALL_PREFIXES(ProfileSyncServiceSessionTest, ValidTabs);
@@ skipping 297 matching lines @@
   std::map<std::string, linked_ptr<SyncedFaviconInfo> > synced_favicons_;
   // Map of page URL -> favicon url.
   std::map<std::string, std::string> synced_favicon_pages_;
 
   DISALLOW_COPY_AND_ASSIGN(SessionModelAssociator);
 };
 
 }  // namespace browser_sync
 
 #endif  // CHROME_BROWSER_SYNC_GLUE_SESSION_MODEL_ASSOCIATOR_H_