Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3243)

Unified Diff: build/config/android/internal_rules.gni

Issue 1129773004: Fix a dependency issue w/ gn refs for android apks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mb_handle_labels
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/android/internal_rules.gni
diff --git a/build/config/android/internal_rules.gni b/build/config/android/internal_rules.gni
index 2a7a8921ed37fbd994a208877a58ec7ab52a0bca..547a8d0ebe5aad625b1aeb4056bda46b128091ec 100644
--- a/build/config/android/internal_rules.gni
+++ b/build/config/android/internal_rules.gni
@@ -616,6 +616,12 @@ template("create_apk") {
group(target_name) {
deps = [
":${target_name}__finalize",
+
+ # TODO: crbug.com/487897 - __finalize needs as input a file created
brettw 2015/05/14 16:42:51 I don't understand this comment. As we talked abou
Dirk Pranke 2015/05/14 17:27:06 Yeah, reading it in the morning, I don't think thi
+ # by __package_resources. We explicitly declare this as a dependency
+ # so that 'gn refs' knows about it (and hence 'mb analyze' will work
+ # correctly).
+ ":${target_name}__package_resources",
]
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698