Fix a dependency issue w/ gn refs for android apks.

build/config/android/internal_rules.gni

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 
 assert(is_android)
 
 rebased_android_sdk = rebase_path(android_sdk, root_build_dir)
 rebased_android_sdk_root = rebase_path(android_sdk_root, root_build_dir)
@@ skipping 598 matching lines @@
         "--load-library-from-zip-file=1",
         "--rezip-apk-jar-path",
         rebase_path(_rezip_jar_path, root_build_dir),
       ]
     }
   }
 
   group(target_name) {
     deps = [
       ":${target_name}__finalize",
+
+      # TODO: crbug.com/487897 - __finalize needs as input a file created

[brettw, 2015/05/14 16:42:51]

I don't understand this comment. As we talked about, "gn refs" isn't broken and
we're not working around it, and there's nothing to fix in the future. If you
have a dependency, you should declare it in the deps.

[Dirk Pranke, 2015/05/14 17:27:06]

Yeah, reading it in the morning, I don't think this comment captured the right
thing.

I was trying to capture two different thoughts, I think. 

The first was an explanation of why this change was needed, which probably
could've been a comment on the CL rather than in the code, or it could be a
comment in the code, but just not a TODO.

The second thing was to capture the idea that when 'gn check' will be able to
check that inputs are not declared as dependencies, we should make sure that
this particular one is caught correctly. That was the "TODO" part.

Does that make sense?

+      # by __package_resources. We explicitly declare this as a dependency
+      # so that 'gn refs' knows about it (and hence 'mb analyze' will work
+      # correctly).
+      ":${target_name}__package_resources",
     ]
   }
 }
 
 template("java_prebuilt_impl") {
   set_sources_assignment_filter([])
   if (defined(invoker.testonly)) {
     testonly = invoker.testonly
   }
   _supports_android =
@@ skipping 541 matching lines @@
     ]
     output = invoker.dex_path
     dex_arg_key = "${rebased_build_config}:final_dex:dependency_dex_files"
     args = [ "--inputs=@FileArg($dex_arg_key)" ]
     if (defined(invoker.excluded_jars)) {
       excluded_jars = rebase_path(invoker.excluded_jars, root_build_dir)
       args += [ "--excluded-paths=${excluded_jars}" ]
     }
   }
 }