Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1127133002: Add v8_extra_library_files to gn (Closed)

Created:
5 years, 7 months ago by domenic
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add v8_extra_library_files to gn This is required for https://codereview.chromium.org/1129743003/ R=jochen@chromium.org BUG= Committed: https://crrev.com/a1180e3ef61fe954a8333b6d9df2a691a5034b6d Cr-Commit-Position: refs/heads/master@{#328536}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/module_args/v8.gni View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
domenic
5 years, 7 months ago (2015-05-06 14:40:23 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-05-06 14:43:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127133002/1
5 years, 7 months ago (2015-05-06 14:44:49 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-06 15:05:45 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 15:06:33 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a1180e3ef61fe954a8333b6d9df2a691a5034b6d
Cr-Commit-Position: refs/heads/master@{#328536}

Powered by Google App Engine
This is Rietveld 408576698