Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issue 1129733006: Omnibox - Code Cleanup - Remove Unnecessary is_history_what_you_typed_match (Closed)

Created:
5 years, 7 months ago by Mark P
Modified:
5 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, arv+watch_chromium.org, darin (slow to review), James Su, ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Omnibox - Code Cleanup - Remove Unnecessary is_history_what_you_typed_match I audited the code in the process of removing this. It seems safe to me. Note that HistoryURL provider isn't the only provider to create a match of type URL_WHAT_YOU_TYPED--ZeroSuggest does too. I thought about creating a helper function that tests for URL_WHAT_YOU_TYPED from the HistoryURL provider and using that where is_history_what_you_typed_match is currently used. Doing so would be exactly equivalent to the current logic. However, I looked at all the places is_history_what_you_typed_match is used, and I see no harm in doing the simpler test (i.e., check only for URL_WHAT_YOU_TYPED, not URL_WHAT_YOU_TYPED from HistoryURL provider). TBR=estade for trivial change to omnibox.js BUG=471360 Committed: https://crrev.com/13a6e5b3ce19c0282b06cf15c13dc6356ea85259 Cr-Commit-Position: refs/heads/master@{#330843}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -24 lines) Patch
M chrome/browser/autocomplete/history_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_url_provider.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/zero_suggest_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/omnibox/omnibox.js View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_model.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_popup_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/omnibox/omnibox.mojom View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/omnibox/omnibox_ui_handler.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/omnibox/autocomplete_match.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/omnibox/autocomplete_match.cc View 4 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Mark P
Peter, please take a look. thanks, mark
5 years, 7 months ago (2015-05-20 18:08:21 UTC) #2
Peter Kasting
LGTM
5 years, 7 months ago (2015-05-20 20:07:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129733006/1
5 years, 7 months ago (2015-05-20 20:26:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/65013)
5 years, 7 months ago (2015-05-20 20:40:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129733006/1
5 years, 7 months ago (2015-05-20 20:42:42 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 23:37:49 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 23:38:42 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/13a6e5b3ce19c0282b06cf15c13dc6356ea85259
Cr-Commit-Position: refs/heads/master@{#330843}

Powered by Google App Engine
This is Rietveld 408576698