DescriptionOmnibox - Code Cleanup - Remove Unnecessary is_history_what_you_typed_match
I audited the code in the process of removing this. It seems safe to me.
Note that HistoryURL provider isn't the only provider to create a match
of type URL_WHAT_YOU_TYPED--ZeroSuggest does too. I thought about
creating a helper function that tests for URL_WHAT_YOU_TYPED from the
HistoryURL provider and using that where is_history_what_you_typed_match
is currently used. Doing so would be exactly equivalent to the current
logic. However, I looked at all the places is_history_what_you_typed_match
is used, and I see no harm in doing the simpler test (i.e., check only for
URL_WHAT_YOU_TYPED, not URL_WHAT_YOU_TYPED from HistoryURL provider).
TBR=estade
for trivial change to omnibox.js
BUG=471360
Committed: https://crrev.com/13a6e5b3ce19c0282b06cf15c13dc6356ea85259
Cr-Commit-Position: refs/heads/master@{#330843}
Patch Set 1 #Messages
Total messages: 11 (4 generated)
|