Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3005)

Unified Diff: chrome/browser/autocomplete/history_url_provider.cc

Issue 1129733006: Omnibox - Code Cleanup - Remove Unnecessary is_history_what_you_typed_match (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/history_url_provider.cc
diff --git a/chrome/browser/autocomplete/history_url_provider.cc b/chrome/browser/autocomplete/history_url_provider.cc
index b11014ee63a67c257122cb258ce4f3cd7efc036d..4e000f8f416ae1f73c050007901558563250e88c 100644
--- a/chrome/browser/autocomplete/history_url_provider.cc
+++ b/chrome/browser/autocomplete/history_url_provider.cc
@@ -645,8 +645,6 @@ AutocompleteMatch HistoryURLProvider::SuggestExactInput(
match.contents.length(), ACMatchClassification::URL,
&match.contents_class);
}
-
- match.is_history_what_you_typed_match = true;
}
return match;
@@ -778,9 +776,9 @@ void HistoryURLProvider::DoAutocomplete(history::HistoryBackend* backend,
// Check whether what the user typed appears in history.
const bool can_check_history_for_exact_match =
- // Checking what_you_typed_match.is_history_what_you_typed_match tells us
+ // Checking what_you_typed_match.allowed_to_be_default_match tells us
// whether SuggestExactInput() succeeded in constructing a valid match.
- params->what_you_typed_match.is_history_what_you_typed_match &&
+ params->what_you_typed_match.allowed_to_be_default_match &&
// Additionally, in the case where the user has typed "foo.com" and
// visited (but not typed) "foo/", and the input is "foo", the first pass
// will fall into the FRONT_HISTORY_MATCH case for "foo.com" but the
« no previous file with comments | « chrome/browser/autocomplete/history_provider.cc ('k') | chrome/browser/autocomplete/zero_suggest_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698