|
Revert of Resolve references to "this" the same way as normal variables (patchset #2 id:20001 of https://codereview.chromium.org/1130733003/)
Reason for revert:
[Sheriff] Breaks jetstream benchmark with errors like this:
>>> Running suite: JetStream/bigfib.cpp
>>> Stdout (#1):
undefined:93: ReferenceError: this is not defined
this['Module'] = Module;
^
ReferenceError: this is not defined
at eval (eval at __run (runner.js:13:3), <anonymous>:93:3)
at eval (native)
at __run (runner.js:13:3)
at Object.runSimpleBenchmark (runner.js:44:31)
at runner.js:97:13
Original issue's description:
> Resolve references to "this" the same way as normal variables
>
> Make the parser handle references to "this" as unresolved variables, so the
> same logic as for the rest of function parameters is used for the receiver.
> Minor additions to the code generation handle copying the receiver to the
> context, along with the rest of the function parameters.
>
> Based on work by Adrian Perez de Castro < aperez@igalia.com>.
>
> BUG= v8:2700
> LOG=N
>
> Committed: https://crrev.com/06a792b7cc2db33ffce7244c044a9c05afbb6116
> Cr-Commit-Position: refs/heads/master@{#28263}
TBR=rossberg@chromium.org,arv@chromium.org,wingo@igalia.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= v8:2700
Committed: https://crrev.com/5cab6be83a44567a3ee5747d728a399025d38411
Cr-Commit-Position: refs/heads/master@{#28283}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+123 lines, -316 lines) |
Patch |
|
M |
src/arm/full-codegen-arm.cc
|
View
|
|
3 chunks |
+5 lines, -7 lines |
0 comments
|
Download
|
|
M |
src/arm/lithium-codegen-arm.cc
|
View
|
|
2 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
|
M |
src/arm64/full-codegen-arm64.cc
|
View
|
|
3 chunks |
+5 lines, -7 lines |
0 comments
|
Download
|
|
M |
src/arm64/lithium-codegen-arm64.cc
|
View
|
|
2 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
|
M |
src/compiler/ast-graph-builder.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
src/compiler/ast-graph-builder.cc
|
View
|
|
3 chunks |
+11 lines, -44 lines |
0 comments
|
Download
|
|
M |
src/contexts.cc
|
View
|
|
1 chunk |
+2 lines, -7 lines |
0 comments
|
Download
|
|
M |
src/heap/heap.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
src/ia32/full-codegen-ia32.cc
|
View
|
|
2 chunks |
+3 lines, -6 lines |
0 comments
|
Download
|
|
M |
src/ia32/lithium-codegen-ia32.cc
|
View
|
|
2 chunks |
+4 lines, -5 lines |
0 comments
|
Download
|
|
M |
src/mips/full-codegen-mips.cc
|
View
|
|
3 chunks |
+5 lines, -7 lines |
0 comments
|
Download
|
|
M |
src/mips/lithium-codegen-mips.cc
|
View
|
|
2 chunks |
+4 lines, -5 lines |
0 comments
|
Download
|
|
M |
src/mips64/full-codegen-mips64.cc
|
View
|
|
3 chunks |
+5 lines, -7 lines |
0 comments
|
Download
|
|
M |
src/mips64/lithium-codegen-mips64.cc
|
View
|
|
2 chunks |
+4 lines, -5 lines |
0 comments
|
Download
|
|
M |
src/parser.cc
|
View
|
|
6 chunks |
+9 lines, -14 lines |
0 comments
|
Download
|
|
M |
src/runtime/runtime-debug.cc
|
View
|
|
1 chunk |
+8 lines, -13 lines |
0 comments
|
Download
|
|
M |
src/runtime/runtime-scopes.cc
|
View
|
|
3 chunks |
+3 lines, -17 lines |
0 comments
|
Download
|
|
M |
src/scopeinfo.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
src/scopes.h
|
View
|
|
3 chunks |
+3 lines, -20 lines |
0 comments
|
Download
|
|
M |
src/scopes.cc
|
View
|
|
5 chunks |
+32 lines, -40 lines |
0 comments
|
Download
|
|
M |
src/variables.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/x64/full-codegen-x64.cc
|
View
|
|
3 chunks |
+5 lines, -7 lines |
0 comments
|
Download
|
|
M |
src/x64/lithium-codegen-x64.cc
|
View
|
|
2 chunks |
+4 lines, -5 lines |
0 comments
|
Download
|
|
M |
test/cctest/test-serialize.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
test/mjsunit/debug-scopes.js
|
View
|
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
D |
test/mjsunit/harmony/arrow-functions-this.js
|
View
|
|
1 chunk |
+0 lines, -81 lines |
0 comments
|
Download
|
Total messages: 5 (0 generated)
|