Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: src/compiler/ast-graph-builder.cc

Issue 1129723003: Revert of Resolve references to "this" the same way as normal variables (Closed) Base URL: https://chromium.googlesource.com/v8/v8@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/ast-graph-builder.h ('k') | src/contexts.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/ast-graph-builder.cc
diff --git a/src/compiler/ast-graph-builder.cc b/src/compiler/ast-graph-builder.cc
index 2ef8d6ffcb6914a7e6f01f811fe0eb1bbcdf0061..88422886edeea86ac4d6e8ab9d48cee772484d04 100644
--- a/src/compiler/ast-graph-builder.cc
+++ b/src/compiler/ast-graph-builder.cc
@@ -470,21 +470,15 @@
// Build receiver check for sloppy mode if necessary.
// TODO(mstarzinger/verwaest): Should this be moved back into the CallIC?
- Node* patched_receiver = nullptr;
- if (scope->has_this_declaration()) {
- Node* original_receiver = NewNode(common()->Parameter(0), graph()->start());
- patched_receiver = BuildPatchReceiverToGlobalProxy(original_receiver);
- if (scope->receiver()->IsStackAllocated()) {
- env.Bind(scope->receiver(), patched_receiver);
- }
- }
+ Node* original_receiver = env.Lookup(scope->receiver());
+ Node* patched_receiver = BuildPatchReceiverToGlobalProxy(original_receiver);
+ env.Bind(scope->receiver(), patched_receiver);
// Build function context only if there are context allocated variables.
int heap_slots = info()->num_heap_slots() - Context::MIN_CONTEXT_SLOTS;
if (heap_slots > 0) {
// Push a new inner context scope for the function.
- Node* inner_context =
- BuildLocalFunctionContext(function_context_.get(), patched_receiver);
+ Node* inner_context = BuildLocalFunctionContext(function_context_.get());
ContextScope top_context(this, scope, inner_context);
CreateGraphBody(stack_check);
} else {
@@ -2173,23 +2167,7 @@
// Create node to ask for help resolving potential eval call. This will
// provide a fully resolved callee and the corresponding receiver.
Node* function = GetFunctionClosure();
- // TODO(wingo): ResolvePossibleDirectEval doesn't really need a receiver,
- // now that eval scopes don't have "this" declarations. Remove this hack
- // once ResolvePossibleDirectEval changes.
- Node* receiver;
- {
- Variable* variable = info()->scope()->LookupThis();
- if (variable->IsStackAllocated()) {
- receiver = environment()->Lookup(variable);
- } else {
- DCHECK(variable->IsContextSlot());
- int depth = current_scope()->ContextChainLength(variable->scope());
- bool immutable = variable->maybe_assigned() == kNotAssigned;
- const Operator* op =
- javascript()->LoadContext(depth, variable->index(), immutable);
- receiver = NewNode(op, current_context());
- }
- }
+ Node* receiver = environment()->Lookup(info()->scope()->receiver());
Node* language = jsgraph()->Constant(language_mode());
Node* position = jsgraph()->Constant(info()->scope()->start_position());
const Operator* op =
@@ -2680,36 +2658,25 @@
}
-Node* AstGraphBuilder::BuildLocalFunctionContext(Node* context,
- Node* patched_receiver) {
- Scope* scope = info()->scope();
+Node* AstGraphBuilder::BuildLocalFunctionContext(Node* context) {
Node* closure = GetFunctionClosure();
// Allocate a new local context.
Node* local_context =
- scope->is_script_scope()
- ? BuildLocalScriptContext(scope)
+ info()->scope()->is_script_scope()
+ ? BuildLocalScriptContext(info()->scope())
: NewNode(javascript()->CreateFunctionContext(), closure);
- if (scope->has_this_declaration() && scope->receiver()->IsContextSlot()) {
- DCHECK_NOT_NULL(patched_receiver);
- // Context variable (at bottom of the context chain).
- Variable* variable = scope->receiver();
- DCHECK_EQ(0, scope->ContextChainLength(variable->scope()));
- const Operator* op = javascript()->StoreContext(0, variable->index());
- NewNode(op, local_context, patched_receiver);
- }
-
// Copy parameters into context if necessary.
- int num_parameters = scope->num_parameters();
+ int num_parameters = info()->scope()->num_parameters();
for (int i = 0; i < num_parameters; i++) {
- Variable* variable = scope->parameter(i);
+ Variable* variable = info()->scope()->parameter(i);
if (!variable->IsContextSlot()) continue;
// Temporary parameter node. The parameter indices are shifted by 1
// (receiver is parameter index -1 but environment index 0).
Node* parameter = NewNode(common()->Parameter(i + 1), graph()->start());
// Context variable (at bottom of the context chain).
- DCHECK_EQ(0, scope->ContextChainLength(variable->scope()));
+ DCHECK_EQ(0, info()->scope()->ContextChainLength(variable->scope()));
const Operator* op = javascript()->StoreContext(0, variable->index());
NewNode(op, local_context, parameter);
}
« no previous file with comments | « src/compiler/ast-graph-builder.h ('k') | src/contexts.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698