Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1129493003: Revert of Add support for escaped target names in isolate driver. (Closed)

Created:
5 years, 7 months ago by nyquist
Modified:
5 years, 7 months ago
Reviewers:
Vadim Sh., Nico, M-A Ruel
CC:
chromium-reviews, Avi (use Gerrit), M-A Ruel
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add support for escaped target names in isolate driver. (patchset #8 id:140001 of https://codereview.chromium.org/1103793002/) Reason for revert: Broke interactive_ui_tests and sync_integration_tests on Mac. See first breakage: http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/5606 Possibly need to include the chrome.isolate in the isolates for browser_tests, and the two test suites mentioned above. Original issue's description: > Add support for escaped target names in isolate driver. > > Currently the isolate_driver.py which creates the dependency files > used by the isolate system, does a simple split on all spaces when > trying to identify targets. > > This can fail if the target name contains a space in the name. In > ninja, spaces are escaped with a $-prefix. An example would be > 'Content$ Shell$ Helper.app'. > > This CL adds support for such target names and ensures that they > stay as one item. Doing this uncovered a few missing dependencies > and a missing file in some .isolate-files for the component build > on Mac. > > Original CL: https://codereview.chromium.org/970203003 > > BUG=462248 > > Committed: https://crrev.com/86c49590cbae332dc933cd9ae3f67d240fb1f125 > Cr-Commit-Position: refs/heads/master@{#328236} TBR=vadimsh@chromium.org,thakis@chromium.org,maruel@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=462248 Committed: https://crrev.com/0b08038dc1753d2d417dfa040e63aef21ee8dce5 Cr-Commit-Position: refs/heads/master@{#328289}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -14 lines) Patch
M chrome/chrome.isolate View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/isolate_driver.py View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nyquist
Created Revert of Add support for escaped target names in isolate driver.
5 years, 7 months ago (2015-05-05 06:07:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129493003/1
5 years, 7 months ago (2015-05-05 06:07:27 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-05 06:08:40 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 06:09:30 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b08038dc1753d2d417dfa040e63aef21ee8dce5
Cr-Commit-Position: refs/heads/master@{#328289}

Powered by Google App Engine
This is Rietveld 408576698