Add support for escaped target names in isolate driver.

Add support for escaped target names in isolate driver.

Currently the isolate_driver.py which creates the dependency files
used by the isolate system, does a simple split on all spaces when
trying to identify targets.

This can fail if the target name contains a space in the name. In
ninja, spaces are escaped with a $-prefix. An example would be
'Content$ Shell$ Helper.app'.

This CL adds support for such target names and ensures that they
stay as one item.

BUG=462248
Committed: https://crrev.com/8fb598c1b7b9a6b944e2ec15e989e80cdf7522c0
Cr-Commit-Position: refs/heads/master@{#319356}

[Avi (use Gerrit), 2015-03-03 20:20:30]

avi@chromium.org changed reviewers:
+ avi@chromium.org

[Avi (use Gerrit), 2015-03-03 20:20:30]

https://codereview.chromium.org/970203003/diff/20001/tools/isolate_driver.py
File tools/isolate_driver.py (right):

https://codereview.chromium.org/970203003/diff/20001/tools/isolate_driver.py#...
tools/isolate_driver.py:150: rand = str(uuid.uuid4())
Rather than uuids, can you pick something simple that will never be a normal
part of a name? I'm thinking a unicode character or something. All you need is
something that won't be used as a name, and uuids seem like overkill.

[nyquist, 2015-03-04 02:06:22]

https://codereview.chromium.org/970203003/diff/20001/tools/isolate_driver.py
File tools/isolate_driver.py (right):

https://codereview.chromium.org/970203003/diff/20001/tools/isolate_driver.py#...
tools/isolate_driver.py:150: rand = str(uuid.uuid4())
On 2015/03/03 20:20:30, Avi wrote:
> Rather than uuids, can you pick something simple that will never be a normal
> part of a name? I'm thinking a unicode character or something. All you need is
> something that won't be used as a name, and uuids seem like overkill.

Done.

[Avi (use Gerrit), 2015-03-04 02:13:29]

On 2015/03/04 02:06:22, nyquist wrote:
> https://codereview.chromium.org/970203003/diff/20001/tools/isolate_driver.py
> File tools/isolate_driver.py (right):
> 
>
https://codereview.chromium.org/970203003/diff/20001/tools/isolate_driver.py#...
> tools/isolate_driver.py:150: rand = str(uuid.uuid4())
> On 2015/03/03 20:20:30, Avi wrote:
> > Rather than uuids, can you pick something simple that will never be a normal
> > part of a name? I'm thinking a unicode character or something. All you need
is
> > something that won't be used as a name, and uuids seem like overkill.
> 
> Done.

Slick! LGTM

[nyquist, 2015-03-04 02:14:16]

nyquist@chromium.org changed reviewers:
+ falken@chromium.org

[nyquist, 2015-03-04 02:14:17]

falken: PTAL since you have done edits around this area.
avi: PTAL as reporter of bug

I am unsure how this CL performs. Happy to update if you think there are other
better options. I found the current one to be the cleanest.

Some examples:
- replace '$ ' with magic non-whitespace token, split on ' ' and replace magic
token back to '$ '
- create an empty deque, split original string on ' ', iterate over the
resulting items and check if last character is '$', and if so, merge with next
item, else just insert current item. There are a bunch of variations to this
one.

[falken, 2015-03-04 07:24:40]

Sorry I am totally unfamiliar with this file. I only reverted a change once to
fix the build.

[falken, 2015-03-04 07:27:37]

falken@chromium.org changed reviewers:
+ maruel@chromium.org

[falken, 2015-03-04 07:27:37]

+maruel, who is the original author

[nyquist, 2015-03-04 22:26:27]

nyquist@chromium.org changed reviewers:
+ vadimsh@chromium.org

[nyquist, 2015-03-04 22:26:28]

vadimsh: Seems like maruel is out. Care to take a look?

[Vadim Sh., 2015-03-04 22:57:58]

lgtm

some serious regexp skills you have :)

[Vadim Sh., 2015-03-04 22:58:43]

https://codereview.chromium.org/970203003/diff/80001/tools/isolate_driver.py
File tools/isolate_driver.py (right):

https://codereview.chromium.org/970203003/diff/80001/tools/isolate_driver.py#...
tools/isolate_driver.py:147: return filter(using_blacklist, re.split('(?<!\$) ',
item))
actually, I think you forgot [1:]?

[nyquist, 2015-03-04 23:13:50]

vadimsh: PTAL

Oh; and I believe I forgot to mention, but the reason why I didn't pre-compile
the regexp is that python caches the last few regexpes automatically.

https://codereview.chromium.org/970203003/diff/80001/tools/isolate_driver.py
File tools/isolate_driver.py (right):

https://codereview.chromium.org/970203003/diff/80001/tools/isolate_driver.py#...
tools/isolate_driver.py:147: return filter(using_blacklist, re.split('(?<!\$) ',
item))
On 2015/03/04 22:58:43, Vadim Sh. wrote:
> actually, I think you forgot [1:]?

Doh! Sure did. Fixed.

[Vadim Sh., 2015-03-05 19:21:38]

lgtm

(sorry for delay, the email notification somhow got lost)

[nyquist, 2015-03-05 22:07:34]

The CQ bit was checked by nyquist@chromium.org

[nyquist, 2015-03-05 22:07:34]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/970203003/#ps100001
(title: "Strip out first item like before")

[commit-bot: I haz the power, 2015-03-05 22:09:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/970203003/100001

[commit-bot: I haz the power, 2015-03-05 23:10:33]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-03-05 23:11:51]

Patchset 6 (id:??) landed as
https://crrev.com/8fb598c1b7b9a6b944e2ec15e989e80cdf7522c0
Cr-Commit-Position: refs/heads/master@{#319356}

[Marc Treib, 2015-03-06 15:24:05]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/985753002/ by treib@chromium.org.

The reason for reverting is: Likely broke Mac 10.9 dbg:
http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29....