Source/core/inspector/InspectorDebuggerAgent.h - Issue 1129473003: DevTools: respond with error when Debugger command is sent to disabled debugger agent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorDebuggerAgent.h

Issue 1129473003: DevTools: respond with error when Debugger command is sent to disabled debugger agent (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Addressed comments, added checks in DOMDebugger Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/inspector/CodeGeneratorInspector.py ('K') | « Source/core/inspector/InspectorDOMDebuggerAgent.cpp ('k') | Source/core/inspector/InspectorDebuggerAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InspectorDebuggerAgent.h

diff --git a/Source/core/inspector/InspectorDebuggerAgent.h b/Source/core/inspector/InspectorDebuggerAgent.h

index 308a37034f43f9028c75073f2c7084b643fc4645..43c9ddb0aec1c8fa09e2dee5be57935ae81442da 100644

--- a/Source/core/inspector/InspectorDebuggerAgent.h

+++ b/Source/core/inspector/InspectorDebuggerAgent.h

@@ -141,6 +141,7 @@ public:

void setAsyncOperationBreakpoint(ErrorString*, int operationId) final;

void removeAsyncOperationBreakpoint(ErrorString*, int operationId) final;

+ bool checkEnabled(ErrorString*) override;

void schedulePauseOnNextStatement(InspectorFrontend::Debugger::Reason::Enum breakReason, PassRefPtr<JSONObject> data);

void didFireTimer();

void didHandleEvent();