Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Unified Diff: Source/core/inspector/InspectorDOMDebuggerAgent.cpp

Issue 1129473003: DevTools: respond with error when Debugger command is sent to disabled debugger agent (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed comments, added checks in DOMDebugger Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/InspectorDOMDebuggerAgent.cpp
diff --git a/Source/core/inspector/InspectorDOMDebuggerAgent.cpp b/Source/core/inspector/InspectorDOMDebuggerAgent.cpp
index 3a346da3fd32005eb339a367ad8ca70cfa54495f..6273b7116fca3e3a1ec83f2533a61d1e00aca2c7 100644
--- a/Source/core/inspector/InspectorDOMDebuggerAgent.cpp
+++ b/Source/core/inspector/InspectorDOMDebuggerAgent.cpp
@@ -137,6 +137,19 @@ void InspectorDOMDebuggerAgent::domAgentWasDisabled()
disable(nullptr);
}
+bool InspectorDOMDebuggerAgent::checkEnabled(ErrorString* errorString)
+{
+ if (!m_domAgent->enabled()) {
+ *errorString = "DOM domain required by DOMDebugger is not enabled";
+ return false;
+ }
+ if (!m_debuggerAgent->enabled()) {
+ *errorString = "Debugger domain required by DOMDebugger is not enabled";
+ return false;
+ }
+ return true;
+}
+
void InspectorDOMDebuggerAgent::disable(ErrorString*)
{
m_instrumentingAgents->setInspectorDOMDebuggerAgent(nullptr);

Powered by Google App Engine
This is Rietveld 408576698