Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: Source/bindings/core/v8/ScriptDebugServer.h

Issue 1129473003: DevTools: respond with error when Debugger command is sent to disabled debugger agent (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/core/v8/ScriptDebugServer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/ScriptDebugServer.h
diff --git a/Source/bindings/core/v8/ScriptDebugServer.h b/Source/bindings/core/v8/ScriptDebugServer.h
index 7d4f6b9db1490f3b1b58ec0f5cfa6e0a2154b552..8cf79d9d2393e45527b391ef02d6e9d02b2cd124 100644
--- a/Source/bindings/core/v8/ScriptDebugServer.h
+++ b/Source/bindings/core/v8/ScriptDebugServer.h
@@ -60,6 +60,7 @@ public:
bool enabled() const;
static void setContextDebugData(v8::Local<v8::Context>, const String& contextDebugData);
+ static bool isDebugContext(v8::Local<v8::Context>);
sergeyv 2015/05/05 12:41:10 ?
yurys 2015/05/05 13:13:02 This was a leftover from another patch. Removed.
// Each script inherits debug data from v8::Context where it has been compiled.
// Only scripts whose debug data contains |contextDebugDataSubstring| substring will be reported.
// Passing empty string will result in reporting all scripts.
@@ -131,7 +132,7 @@ protected:
virtual void quitMessageLoopOnPause() = 0;
private:
- void ensureDebuggerScriptCompiled();
+ void compileDebuggerScript();
v8::MaybeLocal<v8::Value> callDebuggerMethod(const char* functionName, int argc, v8::Local<v8::Value> argv[]);
v8::Local<v8::Object> debuggerScriptLocal() const;
void clearBreakpoints();
« no previous file with comments | « no previous file | Source/bindings/core/v8/ScriptDebugServer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698