DevTools: respond with error when Debugger command is sent to disabled debugger agent

Source/bindings/core/v8/ScriptDebugServer.h

 /*
  * Copyright (c) 2010, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 42 matching lines @@
     WTF_MAKE_NONCOPYABLE(ScriptDebugServer);
 public:
     virtual ~ScriptDebugServer();
     DECLARE_VIRTUAL_TRACE();
 
     void enable();
     void disable();
     bool enabled() const;
 
     static void setContextDebugData(v8::Local<v8::Context>, const String& contextDebugData);
+    static bool isDebugContext(v8::Local<v8::Context>);

[sergeyv, 2015/05/05 12:41:10]

?

[yurys, 2015/05/05 13:13:02]

This was a leftover from another patch. Removed.

     // Each script inherits debug data from v8::Context where it has been compiled.
     // Only scripts whose debug data contains |contextDebugDataSubstring| substring will be reported.
     // Passing empty string will result in reporting all scripts.
     void reportCompiledScripts(const String& contextDebugDataSubstring, ScriptDebugListener*);
 
     String setBreakpoint(const String& sourceID, const ScriptBreakpoint&, int* actualLineNumber, int* actualColumnNumber, bool interstatementLocation);
     void removeBreakpoint(const String& breakpointId);
     void setBreakpointsActivated(bool activated);
 
     enum PauseOnExceptionsState {
@@ skipping 51 matching lines @@
 protected:
     explicit ScriptDebugServer(v8::Isolate*);
 
     virtual void clearCompiledScripts();
 
     virtual ScriptDebugListener* getDebugListenerForContext(v8::Local<v8::Context>) = 0;
     virtual void runMessageLoopOnPause(v8::Local<v8::Context>) = 0;
     virtual void quitMessageLoopOnPause() = 0;
 
 private:
-    void ensureDebuggerScriptCompiled();
+    void compileDebuggerScript();
     v8::MaybeLocal<v8::Value> callDebuggerMethod(const char* functionName, int argc, v8::Local<v8::Value> argv[]);
     v8::Local<v8::Object> debuggerScriptLocal() const;
     void clearBreakpoints();
 
     void dispatchDidParseSource(ScriptDebugListener*, v8::Local<v8::Object> sourceObject, CompileResult);
 
     static void breakProgramCallback(const v8::FunctionCallbackInfo<v8::Value>&);
     void handleProgramBreak(ScriptState* pausedScriptState, v8::Local<v8::Object> executionState, v8::Local<v8::Value> exception, v8::Local<v8::Array> hitBreakpoints, bool isPromiseRejection = false);
     static void v8InterruptCallback(v8::Isolate*, void*);
     static void v8DebugEventCallback(const v8::Debug::EventDetails&);
@@ skipping 21 matching lines @@
     RefPtr<ScriptState> m_pausedScriptState;
     bool m_runningNestedMessageLoop;
     class ThreadSafeTaskQueue;
     OwnPtr<ThreadSafeTaskQueue> m_taskQueue;
 };
 
 } // namespace blink
 
 
 #endif // ScriptDebugServer_h