Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 1129353010: Add Canvas.drawPicture (Closed)

Created:
5 years, 7 months ago by eseidel
Modified:
5 years, 7 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add Canvas.drawPicture I wrote another copy of paint_element_into_displaylist using this new technology. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f7518cc9fa1ce8d25e8d02384abc842f4d2d4c1a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M sky/engine/core/painting/Canvas.h View 2 chunks +3 lines, -0 lines 0 comments Download
M sky/engine/core/painting/Canvas.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M sky/engine/core/painting/Canvas.idl View 1 chunk +2 lines, -0 lines 0 comments Download
A + sky/examples/raw/draw_picture_into_canvas.sky View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
eseidel
5 years, 7 months ago (2015-05-18 22:12:10 UTC) #1
abarth-chromium
lgtm
5 years, 7 months ago (2015-05-18 22:12:33 UTC) #2
eseidel
5 years, 7 months ago (2015-05-18 22:13:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f7518cc9fa1ce8d25e8d02384abc842f4d2d4c1a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698