Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: ui/gfx/vector3d_unittest.cc

Issue 11293193: ui: Add non-member Vector2dScale() and Vector3dScale() methods to create scaled vectors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: use it in cc/ Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/gfx/vector3d_f.cc ('K') | « ui/gfx/vector3d_f.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/vector3d_unittest.cc
diff --git a/ui/gfx/vector3d_unittest.cc b/ui/gfx/vector3d_unittest.cc
index cfac51eab0d0ac3e600b54603bfa85c7e7110754..ebb4edad71410385815267ddc103c4ae6b755f56 100644
--- a/ui/gfx/vector3d_unittest.cc
+++ b/ui/gfx/vector3d_unittest.cc
@@ -91,6 +91,15 @@ TEST(Vector3dTest, Scale) {
EXPECT_EQ(v.x(), triple_values[i][0] * triple_values[i][3]);
EXPECT_EQ(v.y(), triple_values[i][1] * triple_values[i][4]);
EXPECT_EQ(v.z(), triple_values[i][2] * triple_values[i][5]);
+
+ Vector3dF v2 = ScaleVector3d(
+ gfx::Vector3dF(triple_values[i][0],
+ triple_values[i][1],
+ triple_values[i][2]),
+ triple_values[i][3], triple_values[i][4], triple_values[i][5]);
+ EXPECT_EQ(v2.x(), triple_values[i][0] * triple_values[i][3]);
sky 2012/11/09 17:06:21 and order wrong here too.
danakj 2012/11/09 18:21:47 Done.
+ EXPECT_EQ(v2.y(), triple_values[i][1] * triple_values[i][4]);
+ EXPECT_EQ(v2.z(), triple_values[i][2] * triple_values[i][5]);
}
float single_values[][4] = {
@@ -118,6 +127,15 @@ TEST(Vector3dTest, Scale) {
EXPECT_EQ(v.x(), single_values[i][0] * single_values[i][3]);
EXPECT_EQ(v.y(), single_values[i][1] * single_values[i][3]);
EXPECT_EQ(v.z(), single_values[i][2] * single_values[i][3]);
+
+ Vector3dF v2 = ScaleVector3d(
+ gfx::Vector3dF(single_values[i][0],
+ single_values[i][1],
+ single_values[i][2]),
+ single_values[i][3]);
+ EXPECT_EQ(v2.x(), single_values[i][0] * single_values[i][3]);
+ EXPECT_EQ(v2.y(), single_values[i][1] * single_values[i][3]);
+ EXPECT_EQ(v2.z(), single_values[i][2] * single_values[i][3]);
}
}
« ui/gfx/vector3d_f.cc ('K') | « ui/gfx/vector3d_f.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698