ui: Add non-member Vector2dScale() and Vector3dScale() methods to create scaled vectors

ui: Add non-member Vector2dScale() and Vector3dScale() methods to create scaled vectors

These behave like similar methods for Rect/Point/Size.

Tests:
ui_unittests:Vector2dTest.Scale
ui_unittests:Vector3dTest.Scale

R=sky
BUG=160158
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=166993

[sky, 2012-11-09 17:06:21]

LGTM

https://codereview.chromium.org/11293193/diff/8/ui/gfx/vector2d_f.h
File ui/gfx/vector2d_f.h (right):

https://codereview.chromium.org/11293193/diff/8/ui/gfx/vector2d_f.h#newcode88
ui/gfx/vector2d_f.h:88: const Vector2dF& v, float x_scale, float y_scale);
nit: when you wrap, wrap each param on its own line.

https://codereview.chromium.org/11293193/diff/8/ui/gfx/vector2d_unittest.cc
File ui/gfx/vector2d_unittest.cc (right):

https://codereview.chromium.org/11293193/diff/8/ui/gfx/vector2d_unittest.cc#n...
ui/gfx/vector2d_unittest.cc:122: EXPECT_EQ(v2.x(), double_values[i][0] *
double_values[i][2]);
Your The order is wrong here. You want expected,actual.

https://codereview.chromium.org/11293193/diff/8/ui/gfx/vector3d_f.cc
File ui/gfx/vector3d_f.cc (right):

https://codereview.chromium.org/11293193/diff/8/ui/gfx/vector3d_f.cc#newcode80
ui/gfx/vector3d_f.cc:80: const Vector3dF& v, float x_scale, float y_scale, float
z_scale) {
nit on wrapping here too.

https://codereview.chromium.org/11293193/diff/8/ui/gfx/vector3d_f.h
File ui/gfx/vector3d_f.h (right):

https://codereview.chromium.org/11293193/diff/8/ui/gfx/vector3d_f.h#newcode101
ui/gfx/vector3d_f.h:101: const Vector3dF& v, float x_scale, float y_scale, float
z_scale);
nit on the wrapper here too.

https://codereview.chromium.org/11293193/diff/8/ui/gfx/vector3d_unittest.cc
File ui/gfx/vector3d_unittest.cc (right):

https://codereview.chromium.org/11293193/diff/8/ui/gfx/vector3d_unittest.cc#n...
ui/gfx/vector3d_unittest.cc:100: EXPECT_EQ(v2.x(), triple_values[i][0] *
triple_values[i][3]);
and order wrong here too.

[danakj, 2012-11-09 18:21:46]

https://codereview.chromium.org/11293193/diff/8/ui/gfx/vector2d_f.h
File ui/gfx/vector2d_f.h (right):

https://codereview.chromium.org/11293193/diff/8/ui/gfx/vector2d_f.h#newcode88
ui/gfx/vector2d_f.h:88: const Vector2dF& v, float x_scale, float y_scale);
On 2012/11/09 17:06:21, sky wrote:
> nit: when you wrap, wrap each param on its own line.

Done.

https://codereview.chromium.org/11293193/diff/8/ui/gfx/vector2d_unittest.cc
File ui/gfx/vector2d_unittest.cc (right):

https://codereview.chromium.org/11293193/diff/8/ui/gfx/vector2d_unittest.cc#n...
ui/gfx/vector2d_unittest.cc:122: EXPECT_EQ(v2.x(), double_values[i][0] *
double_values[i][2]);
On 2012/11/09 17:06:21, sky wrote:
> Your The order is wrong here. You want expected,actual.

Oops, thanks.

https://codereview.chromium.org/11293193/diff/8/ui/gfx/vector3d_f.cc
File ui/gfx/vector3d_f.cc (right):

https://codereview.chromium.org/11293193/diff/8/ui/gfx/vector3d_f.cc#newcode80
ui/gfx/vector3d_f.cc:80: const Vector3dF& v, float x_scale, float y_scale, float
z_scale) {
On 2012/11/09 17:06:21, sky wrote:
> nit on wrapping here too.

Done.

https://codereview.chromium.org/11293193/diff/8/ui/gfx/vector3d_f.h
File ui/gfx/vector3d_f.h (right):

https://codereview.chromium.org/11293193/diff/8/ui/gfx/vector3d_f.h#newcode101
ui/gfx/vector3d_f.h:101: const Vector3dF& v, float x_scale, float y_scale, float
z_scale);
On 2012/11/09 17:06:21, sky wrote:
> nit on the wrapper here too.

Done.

https://codereview.chromium.org/11293193/diff/8/ui/gfx/vector3d_unittest.cc
File ui/gfx/vector3d_unittest.cc (right):

https://codereview.chromium.org/11293193/diff/8/ui/gfx/vector3d_unittest.cc#n...
ui/gfx/vector3d_unittest.cc:100: EXPECT_EQ(v2.x(), triple_values[i][0] *
triple_values[i][3]);
On 2012/11/09 17:06:21, sky wrote:
> and order wrong here too.

Done.

[commit-bot: I haz the power, 2012-11-09 19:58:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/11293193/10001

[danakj, 2012-11-09 19:59:24]

+enne for cc/ changes

[enne (OOO), 2012-11-09 20:32:07]

cc lgtm

[commit-bot: I haz the power, 2012-11-09 20:37:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/11293193/10001