Compare :lang value case-insensitive in ASCII range

Compare :lang value case-insensitive in ASCII range

Compare :lang value case-insensitive in ASCII range, relevant
spec information [1]:
"All CSS syntax is case-insensitive within the ASCII range (i.e.,
[a-z] and [A-Z] are equivalent), except for parts that are not
under the control of CSS."

Add methods to be able to do a comparison that is case-insensitive
within the ASCII range to wtf.

Test taken from:
https://test.csswg.org/source/css21/syntax/case-sensitive-004.xht

Behavior matches Firefox.

[1] http://www.w3.org/TR/CSS21/syndata.html#characters

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195333

[rwlbuis, 2015-05-08 00:06:57]

rob.buis@samsung.com changed reviewers:
+ timloh@chromium.org

[rwlbuis, 2015-05-08 00:06:57]

PTAL. Sorry for the amount of reviews :)

[Timothy Loh, 2015-05-10 23:31:44]

Similar comment to the other patch, but this one I'm not sure if it's actually
correct.

http://dev.w3.org/csswg/selectors-4/#the-lang-pseudo -> "The matching is
performed case-insensitively within the ASCII range."

If we have both ascii and non-ascii characters in the pseudo-class, this code
won't match when the non-ascii characters are the same but the ascii characters
differ in case.

[rwlbuis, 2015-05-11 20:36:47]

On 2015/05/10 23:31:44, Timothy Loh wrote:
> Similar comment to the other patch, but this one I'm not sure if it's actually
> correct.
> 
> http://dev.w3.org/csswg/selectors-4/#the-lang-pseudo -> "The matching is
> performed case-insensitively within the ASCII range."
> 
> If we have both ascii and non-ascii characters in the pseudo-class, this code
> won't match when the non-ascii characters are the same but the ascii
characters
> differ in case.

Right, I now added code to do that kind of matching, PTAL.

[Timothy Loh, 2015-05-11 23:45:08]

lgtm, but you might need to find a wtf/ OWNER.

On 2015/05/11 20:36:47, rwlbuis wrote:
> On 2015/05/10 23:31:44, Timothy Loh wrote:
> > Similar comment to the other patch, but this one I'm not sure if it's
actually
> > correct.
> > 
> > http://dev.w3.org/csswg/selectors-4/#the-lang-pseudo -> "The matching is
> > performed case-insensitively within the ASCII range."
> > 
> > If we have both ascii and non-ascii characters in the pseudo-class, this
code
> > won't match when the non-ascii characters are the same but the ascii
> characters
> > differ in case.
> 
> Right, I now added code to do that kind of matching, PTAL.

Test?

[rwlbuis, 2015-05-12 00:08:39]

rob.buis@samsung.com changed reviewers:
+ tkent@chromium.org

[rwlbuis, 2015-05-12 00:08:39]

@tkent PTAL at the wtf change.

[rwlbuis, 2015-05-12 21:47:42]

On 2015/05/11 23:45:08, Timothy Loh wrote:
> lgtm, but you might need to find a wtf/ OWNER.
> 
> On 2015/05/11 20:36:47, rwlbuis wrote:
> > On 2015/05/10 23:31:44, Timothy Loh wrote:
> > Right, I now added code to do that kind of matching, PTAL.
> 
> Test?

Added.

[tkent, 2015-05-13 01:07:55]

Adding fooIgnoringASCIICase() functions is ok this time.

Ideally, we should add TextCaseASCIIInsensitive to TextCaseSensitivity enum, and
re-check all usage of TextCaseSensitivity.

https://codereview.chromium.org/1129313003/diff/60001/Source/wtf/text/WTFStri...
File Source/wtf/text/WTFStringTest.cpp (right):

https://codereview.chromium.org/1129313003/diff/60001/Source/wtf/text/WTFStri...
Source/wtf/text/WTFStringTest.cpp:323:
ASSERT_TRUE(startsWithIgnoringASCIICase(allASCII, allASCIILowerCase));
This should be EXPECT_TRUE(), not ASSERT_TRUE().
Same for the following ASSERT_*().

[rwlbuis, 2015-05-13 21:17:18]

On 2015/05/13 01:07:55, Slow until end of May wrote:
> Adding fooIgnoringASCIICase() functions is ok this time.
> 
> Ideally, we should add TextCaseASCIIInsensitive to TextCaseSensitivity enum,
and
> re-check all usage of TextCaseSensitivity.

Good idea. I added the minimal amount to fix the problem so far, but this can
definitely be extended.

>
https://codereview.chromium.org/1129313003/diff/60001/Source/wtf/text/WTFStri...
> File Source/wtf/text/WTFStringTest.cpp (right):
> 
>
https://codereview.chromium.org/1129313003/diff/60001/Source/wtf/text/WTFStri...
> Source/wtf/text/WTFStringTest.cpp:323:
> ASSERT_TRUE(startsWithIgnoringASCIICase(allASCII, allASCIILowerCase));
> This should be EXPECT_TRUE(), not ASSERT_TRUE().
> Same for the following ASSERT_*().

Fixed.

[tkent, 2015-05-13 23:30:15]

The CQ bit was checked by tkent@chromium.org

[tkent, 2015-05-13 23:30:16]

lgtm

[tkent, 2015-05-13 23:30:16]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/1129313003/#ps80001
(title: "Use EXPECT instead of ASSERT")

[commit-bot: I haz the power, 2015-05-13 23:30:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1129313003/80001

[commit-bot: I haz the power, 2015-05-14 00:56:43]

Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195333