Source/core/css/SelectorChecker.cpp - Issue 1129313003: Compare :lang value case-insensitive in ASCII range

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/SelectorChecker.cpp

Issue 1129313003: Compare :lang value case-insensitive in ASCII range (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Use EXPECT instead of ASSERT Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/SelectorChecker.cpp

diff --git a/Source/core/css/SelectorChecker.cpp b/Source/core/css/SelectorChecker.cpp

index 8c46bd91176849a0eada246d00bb726c8abc55cb..6b882bd448a3b3961b26fdc1b1708b0a48f3352e 100644

--- a/Source/core/css/SelectorChecker.cpp

+++ b/Source/core/css/SelectorChecker.cpp

@@ -964,7 +964,7 @@ bool SelectorChecker::checkPseudoClass(const SelectorCheckingContext& context, u

else

value = element.computeInheritedLanguage();

const AtomicString& argument = selector.argument();

- if (value.isEmpty() || !value.startsWith(argument, TextCaseInsensitive))

+ if (value.isEmpty() || !startsWithIgnoringASCIICase(value, argument))

break;

if (value.length() != argument.length() && value[argument.length()] != '-')

break;

« no previous file with comments | « LayoutTests/fast/css/case-sensitive-004-expected.xhtml ('k') | Source/wtf/text/StringImpl.h » ('j') | no next file with comments »