Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 11293101: Stop emitting warnings for mime types not recognized by Android. (Closed)

Created:
8 years, 1 month ago by Peter Beverloo
Modified:
8 years, 1 month ago
Reviewers:
bulach, Yaron
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, digit1
Visibility:
Public.

Description

Stop emitting warnings for mime types not recognized by Android. Chromium attempts to get mime types based on extensions by (1) checking the primary list in mime_util.cc, (2) querying the OS for the mime type or (3) checking the list of secondary mappings. For Android, a warning message is being emitted when an extension can't be found during step (2), which calls URLConnection.guessContentTypeFromName in Java. The most common extension causing the warning is "js", which will be resolved as part of the secondary mappings in step (3). This voids the warning. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166192

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M net/android/network_library.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Peter Beverloo
+Marcus as this touches bindings. +Yaron as you're the OWNER.
8 years, 1 month ago (2012-11-05 20:07:12 UTC) #1
Peter Beverloo
For further reference, the actual resolving happens in mime_util.cc: http://src.chromium.org/viewvc/chrome/trunk/src/net/base/mime_util.cc?revision=164346&view=markup Around line 210 you'll find ...
8 years, 1 month ago (2012-11-05 20:10:16 UTC) #2
Yaron
lgtm
8 years, 1 month ago (2012-11-05 23:17:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/11293101/1
8 years, 1 month ago (2012-11-06 10:32:51 UTC) #4
commit-bot: I haz the power
8 years, 1 month ago (2012-11-06 12:27:09 UTC) #5
Change committed as 166192

Powered by Google App Engine
This is Rietveld 408576698