Merge chrome perf graphing change into Chrome Endure fork of graphing code.

chrome/test/functional/perf/endure_graphs/js/common.js

 /*
   Copyright (c) 2012 The Chromium Authors. All rights reserved.
   Use of this source code is governed by a BSD-style license that can be
   found in the LICENSE file.
 */
 
 /**
  * @fileoverview Common methods for performance-plotting Javascript.
  */
 
@@ skipping 59 matching lines @@
   return result;
 }
 
 /**
  * Creates the URL constructed from the current pathname and the given params.
  *
  * @param {Object} An object containing parameters for a URL query string.
  * @return {string} The URL constructed from the given params.
  */
 function MakeURL(params) {
-  var url = window.location.pathname;
-  var sep = '?';
-  for (p in params) {
-    if (!p)
-      continue;
-    url += sep + p + '=' + params[p];
-    sep = '&';
+  var arr = [];
+  for (var p in params) {
+    if (typeof params[p] == 'object') {
+      // Repeated params, stored as hash like {valueA: 1, valueB: 1}
+      for (var r in params[p]) {
+        arr.push(p + '=' + r);

[alias of yukishiino, 2012/11/02 04:19:19]

I'm not sure if it's necessary to check the value of 'valueA' is 1 or 0 (true or
false, or any other values).  If no need, it's okay.

[alias of yukishiino, 2012/11/02 04:19:19]

You should call encodeURIComponent for each value.  It seems you're using raw
strings.

+      }
+    } else {
+      arr.push(p + '=' + params[p]);
+    }
   }
-  return url;
+  return window.location.pathname + '?' + arr.join('&');
 }