Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 11293043: Merge chrome perf graphing change into Chrome Endure fork of graphing code.

Created:
8 years, 1 month ago by dennis_jeffrey
Modified:
7 years, 10 months ago
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1
Visibility:
Public.

Description

Merge chrome perf graphing change into Chrome Endure fork of graphing code. The following change was previously made to the chrome perf graphing infrastructure: https://chromiumcodereview.appspot.com/11184003/ The current CL makes the same change in the Chrome Endure graphing code that is currently a fork of the original Chrome perf graphing code. BUG=chromium-os:33935 TEST=None

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M chrome/test/functional/perf/endure_graphs/js/common.js View 1 chunk +11 lines, -8 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
dennis_jeffrey
Hi Dai, This is a small change to the Chrome Endure graphing code. Could you ...
8 years, 1 month ago (2012-11-01 21:45:03 UTC) #1
Dai Mikurube (NOT FULLTIME)
+yukishiino lgtm. But, I'd like to wait for yukishiino's comments.
8 years, 1 month ago (2012-11-02 03:40:25 UTC) #2
alias of yukishiino
https://chromiumcodereview.appspot.com/11293043/diff/1/chrome/test/functional/perf/endure_graphs/js/common.js File chrome/test/functional/perf/endure_graphs/js/common.js (right): https://chromiumcodereview.appspot.com/11293043/diff/1/chrome/test/functional/perf/endure_graphs/js/common.js#newcode85 chrome/test/functional/perf/endure_graphs/js/common.js:85: arr.push(p + '=' + r); I'm not sure if ...
8 years, 1 month ago (2012-11-02 04:19:19 UTC) #3
Dai Mikurube (NOT FULLTIME)
7 years, 10 months ago (2013-01-30 07:24:01 UTC) #4
Hi Dennis,

Has it been forgotten?  What do you think?

Powered by Google App Engine
This is Rietveld 408576698