Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 1129303002: Expose chromecast extension ids for usage by cast system tray integration (Closed)

Created:
5 years, 7 months ago by jdufault
Modified:
5 years, 7 months ago
Reviewers:
achuithb, hubbe
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose chromecast extension ids for usage by cast system tray integration For additional context, see: - https://codereview.chromium.org/1118613003/ - https://codereview.chromium.org/1115083002/ BUG=433140 Committed: https://crrev.com/a666b56d05b0722ff1a89d22a6f8885fe7a202b8 Cr-Commit-Position: refs/heads/master@{#329451}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Patch Set 3 : Fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -13 lines) Patch
M chrome/browser/extensions/api/tab_capture/tab_capture_api.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_api.cc View 1 2 3 chunks +14 lines, -13 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
jdufault
5 years, 7 months ago (2015-05-07 19:55:16 UTC) #2
achuithb
https://codereview.chromium.org/1129303002/diff/1/chrome/browser/extensions/api/tab_capture/tab_capture_api.cc File chrome/browser/extensions/api/tab_capture/tab_capture_api.cc (right): https://codereview.chromium.org/1129303002/diff/1/chrome/browser/extensions/api/tab_capture/tab_capture_api.cc#newcode38 chrome/browser/extensions/api/tab_capture/tab_capture_api.cc:38: // Whitelisted extensions that do not check for a ...
5 years, 7 months ago (2015-05-08 04:44:43 UTC) #3
achuithb
Justin, could you please take a look
5 years, 7 months ago (2015-05-08 04:48:31 UTC) #5
achuithb
Looks like Justin is OOO. Hubbe, could you please take a look.
5 years, 7 months ago (2015-05-08 04:52:01 UTC) #7
hubbe
lgtm https://codereview.chromium.org/1129303002/diff/1/chrome/browser/extensions/api/tab_capture/tab_capture_api.cc File chrome/browser/extensions/api/tab_capture/tab_capture_api.cc (right): https://codereview.chromium.org/1129303002/diff/1/chrome/browser/extensions/api/tab_capture/tab_capture_api.cc#newcode38 chrome/browser/extensions/api/tab_capture/tab_capture_api.cc:38: // Whitelisted extensions that do not check for ...
5 years, 7 months ago (2015-05-12 17:25:42 UTC) #8
jdufault
https://codereview.chromium.org/1129303002/diff/1/chrome/browser/extensions/api/tab_capture/tab_capture_api.cc File chrome/browser/extensions/api/tab_capture/tab_capture_api.cc (right): https://codereview.chromium.org/1129303002/diff/1/chrome/browser/extensions/api/tab_capture/tab_capture_api.cc#newcode38 chrome/browser/extensions/api/tab_capture/tab_capture_api.cc:38: // Whitelisted extensions that do not check for a ...
5 years, 7 months ago (2015-05-12 18:08:54 UTC) #9
jdufault
https://codereview.chromium.org/1129303002/diff/1/chrome/browser/extensions/api/tab_capture/tab_capture_api.cc File chrome/browser/extensions/api/tab_capture/tab_capture_api.cc (right): https://codereview.chromium.org/1129303002/diff/1/chrome/browser/extensions/api/tab_capture/tab_capture_api.cc#newcode38 chrome/browser/extensions/api/tab_capture/tab_capture_api.cc:38: // Whitelisted extensions that do not check for a ...
5 years, 7 months ago (2015-05-12 18:16:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129303002/40001
5 years, 7 months ago (2015-05-12 18:18:44 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-12 19:22:43 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 19:23:27 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a666b56d05b0722ff1a89d22a6f8885fe7a202b8
Cr-Commit-Position: refs/heads/master@{#329451}

Powered by Google App Engine
This is Rietveld 408576698