Expose chromecast extension ids for usage by cast system tray integration

chrome/browser/extensions/api/tab_capture/tab_capture_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Implements the Chrome Extensions Tab Capture API.
 
 #include "chrome/browser/extensions/api/tab_capture/tab_capture_api.h"
 
 #include <set>
 #include <string>
@@ skipping 17 matching lines @@
 #include "extensions/common/permissions/permissions_data.h"
 #include "extensions/common/switches.h"
 
 using extensions::api::tab_capture::MediaStreamConstraint;
 
 namespace TabCapture = extensions::api::tab_capture;
 namespace GetCapturedTabs = TabCapture::GetCapturedTabs;
 
 namespace extensions {
 
+// Whitelisted extensions that do not check for a browser action grant because

[achuithb, 2015/05/08 04:44:43]

I'd move this code to below the anonymous namespace for consistency with the
rest of the codebase.

[hubbe, 2015/05/12 17:25:41]

I also think this should be moved.

[jdufault, 2015/05/12 18:08:54]

Done.

[jdufault, 2015/05/12 18:16:38]

This broke the build (since kChromecastExtensionIds needs to refer to
extensions::kChromecastExtensionIds), so I moved it to be below the anonymous
namespace but within the extensions namespace.

+// they provide API's. If there are additional extension ids that need
+// whitelisting and are *not* the Chromecast extension, add them to a new
+// kWhitelist array.
+const char* const kChromecastExtensionIds[] = {
+    "enhhojjnijigcajfphajepfemndkmdlo",  // Dev
+    "pkedcjkdefgpdelpbcmbmeomcjbeemfm",  // Dogfood
+    "fmfcbgogabcbclcofgocippekhfcmgfj",  // Staging
+    "hfaagokkkhdbgiakmmlclaapfelnkoah",  // Canary
+    "dliochdbjfkdbacpmhlcpmleaejidimm",  // Google Cast Beta
+    "boadgeojelhgndaghljhdicfkmllpafd",  // Google Cast Stable
+};
+
 namespace {
 
 const char kCapturingSameTab[] = "Cannot capture a tab with an active stream.";
 const char kFindingTabError[] = "Error finding tab to capture.";
 const char kNoAudioOrVideo[] = "Capture failed. No audio or video requested.";
 const char kGrantError[] =
     "Extension has not been invoked for the current page (see activeTab "
     "permission). Chrome pages cannot be captured.";
 
 // Keys/values for media stream constraints.
 const char kMediaStreamSource[] = "chromeMediaSource";
 const char kMediaStreamSourceId[] = "chromeMediaSourceId";
 const char kMediaStreamSourceTab[] = "tab";
 
-// Whitelisted extensions that do not check for a browser action grant because
-// they provide API's.
-const char* const kWhitelist[] = {
-  "enhhojjnijigcajfphajepfemndkmdlo",  // Dev
-  "pkedcjkdefgpdelpbcmbmeomcjbeemfm",  // Trusted Tester
-  "fmfcbgogabcbclcofgocippekhfcmgfj",  // Staging
-  "hfaagokkkhdbgiakmmlclaapfelnkoah",  // Canary
-  "F155646B5D1CA545F7E1E4E20D573DFDD44C2540",  // Trusted Tester (public)
-  "16CA7A47AAE4BE49B1E75A6B960C3875E945B264"   // Release
-};
-
 }  // namespace
 
 bool TabCaptureCaptureFunction::RunSync() {
   scoped_ptr<api::tab_capture::Capture::Params> params =
       TabCapture::Capture::Params::Create(*args_);
   EXTENSION_FUNCTION_VALIDATE(params.get());
 
   // Figure out the active WebContents and retrieve the needed ids.
   Browser* target_browser = chrome::FindAnyBrowser(
       GetProfile(), include_incognito(), chrome::GetActiveDesktop());
@@ skipping 11 matching lines @@
 
   const std::string& extension_id = extension()->id();
 
   // Make sure either we have been granted permission to capture through an
   // extension icon click or our extension is whitelisted.
   if (!extension()->permissions_data()->HasAPIPermissionForTab(
           SessionTabHelper::IdForTab(target_contents),
           APIPermission::kTabCaptureForTab) &&
       base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
           switches::kWhitelistedExtensionID) != extension_id &&
-      !SimpleFeature::IsIdInArray(
-          extension_id, kWhitelist, arraysize(kWhitelist))) {
+      !SimpleFeature::IsIdInArray(extension_id, kChromecastExtensionIds,
+                                  arraysize(kChromecastExtensionIds))) {
     error_ = kGrantError;
     return false;
   }
 
   // Create a constraints vector. We will modify all the constraints in this
   // vector to append our chrome specific constraints.
   std::vector<MediaStreamConstraint*> constraints;
   bool has_audio = params->options.audio.get() && *params->options.audio.get();
   bool has_video = params->options.video.get() && *params->options.video.get();
 
@@ skipping 51 matching lines @@
 bool TabCaptureGetCapturedTabsFunction::RunSync() {
   TabCaptureRegistry* registry = TabCaptureRegistry::Get(GetProfile());
   base::ListValue* const list = new base::ListValue();
   if (registry)
     registry->GetCapturedTabs(extension()->id(), list);
   SetResult(list);
   return true;
 }
 
 }  // namespace extensions