Issue 11293028: GTTF: remove FAILS_ prefix, part 1

Issue 11293028: GTTF: remove FAILS_ prefix, part 1 (Closed)

Created:
8 years, 1 month ago by Paweł Hajdan Jr.

Modified:
8 years, 1 month ago

Reviewers:
scheib, MAD

CC:
chromium-reviews, sadrul, tburkard+watch_chromium.org, amit, yoshiki+watch_chromium.org, scheib+watch_chromium.org, cbentzel+watch_chromium.org, ben+watch_chromium.org, grt+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, tim (not reviewing), Raghu Simha, gavinp+prer_chromium.org, pam+watch_chromium.org, haitaol1, akalin, tfarina, Aaron Boodman, dominich+watch_chromium.org, robertshield, mmenke

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

GTTF: remove FAILS_ prefix, part 1 See http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/handling-a-failing-test and https://groups.google.com/a/chromium.org/d/topic/chromium-dev/_OwJ_GWfOaY/discussion BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=165415

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -60 lines)			Patch
M	PRESUBMIT.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/shell_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/wm/base_layout_manager_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/wm/shelf_layout_manager_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/wm/toplevel_window_event_handler_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/wm/window_manager_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/debug/stack_trace_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/gtest_prod_util.h	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	base/json/json_parser.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	base/message_loop_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	base/test/test_suite.cc	View	3 chunks	+1 line, -13 lines	0 comments	Download
M	chrome/browser/browser_keyevents_browsertest.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_service_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/window_open_apitest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/prerender/prerender_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/process_singleton_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/test/integration/single_client_themes_sync_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/test/integration/two_client_themes_sync_test.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/task_manager/task_manager_browsertest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/browser_focus_uitest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/fullscreen/fullscreen_controller_interactive_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/web_ui_browsertest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/service_process_util_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/webui/sample_downloads.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/perf/dom_checker_uitest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/test/perf/tab_switching_test.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
	chrome_frame/test/test_with_web_server.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/render_widget_host_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/events/event_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/gfx/platform_font_pango_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
	ui/views/focus/focus_manager_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/plugin_tests.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

Please do a sanity check on the CL, I hope the reason is clear.

8 years, 1 month ago (2012-10-31 23:49:04 UTC) #1

Sheriff's LGTM!

Expand Messages | Collapse Messages