| OLD | NEW |
| 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Top-level presubmit script for Chromium. | 5 """Top-level presubmit script for Chromium. |
| 6 | 6 |
| 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
| 8 for more details about the presubmit API built into gcl. | 8 for more details about the presubmit API built into gcl. |
| 9 """ | 9 """ |
| 10 | 10 |
| (...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 109 'http://dev.chromium.org/developers/coding-style/cocoa-dos-and-donts', | 109 'http://dev.chromium.org/developers/coding-style/cocoa-dos-and-donts', |
| 110 ), | 110 ), |
| 111 True, | 111 True, |
| 112 ), | 112 ), |
| 113 ) | 113 ) |
| 114 | 114 |
| 115 | 115 |
| 116 _BANNED_CPP_FUNCTIONS = ( | 116 _BANNED_CPP_FUNCTIONS = ( |
| 117 # Make sure that gtest's FRIEND_TEST() macro is not used; the | 117 # Make sure that gtest's FRIEND_TEST() macro is not used; the |
| 118 # FRIEND_TEST_ALL_PREFIXES() macro from base/gtest_prod_util.h should be | 118 # FRIEND_TEST_ALL_PREFIXES() macro from base/gtest_prod_util.h should be |
| 119 # used instead since that allows for FLAKY_, FAILS_ and DISABLED_ prefixes. | 119 # used instead since that allows for FLAKY_ and DISABLED_ prefixes. |
| 120 ( | 120 ( |
| 121 'FRIEND_TEST(', | 121 'FRIEND_TEST(', |
| 122 ( | 122 ( |
| 123 'Chromium code should not use gtest\'s FRIEND_TEST() macro. Include', | 123 'Chromium code should not use gtest\'s FRIEND_TEST() macro. Include', |
| 124 'base/gtest_prod_util.h and use FRIEND_TEST_ALL_PREFIXES() instead.', | 124 'base/gtest_prod_util.h and use FRIEND_TEST_ALL_PREFIXES() instead.', |
| 125 ), | 125 ), |
| 126 False, | 126 False, |
| 127 ), | 127 ), |
| 128 ( | 128 ( |
| 129 'ScopedAllowIO', | 129 'ScopedAllowIO', |
| (...skipping 512 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 642 # Same for ash and chromeos. | 642 # Same for ash and chromeos. |
| 643 if any(re.search('[/_](ash|aura)', f) for f in files): | 643 if any(re.search('[/_](ash|aura)', f) for f in files): |
| 644 trybots += ['linux_chromeos', 'linux_chromeos_clang:compile', 'win_aura', | 644 trybots += ['linux_chromeos', 'linux_chromeos_clang:compile', 'win_aura', |
| 645 'linux_chromeos_asan'] | 645 'linux_chromeos_asan'] |
| 646 else: | 646 else: |
| 647 if any(re.search('[/_]chromeos', f) for f in files): | 647 if any(re.search('[/_]chromeos', f) for f in files): |
| 648 trybots += ['linux_chromeos', 'linux_chromeos_clang:compile', | 648 trybots += ['linux_chromeos', 'linux_chromeos_clang:compile', |
| 649 'linux_chromeos_asan'] | 649 'linux_chromeos_asan'] |
| 650 | 650 |
| 651 return trybots | 651 return trybots |
| OLD | NEW |