Issue 11293005: Move chrome/test/data/chromeos/gdata to chrome/test/data/gdata

Issue 11293005: Move chrome/test/data/chromeos/gdata to chrome/test/data/gdata (Closed)

Created:
8 years, 1 month ago by tzik

Modified:
8 years, 1 month ago

Reviewers:
satorux1

CC:
chromium-reviews, stevenjb+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move chrome/test/data/chromeos/gdata to chrome/test/data/gdata to use it in tests for non-ChromeOS platform. BUG=149788 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=165900

Patch Set 2 : mv chrome/test/data/{chromeos/,}drive #

Patch Set 4 : revert contact/ move #

Patch Set 5 : enable more tests #

Patch Set 7 : use test_util::GetTestFilePath #

Patch Set 9 : rebase #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+-25 lines, -6518 lines)			Patch
M	chrome/browser/google_apis/gdata_test_util.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/google_apis/gdata_wapi_parser_unittest.cc	View	1 2 3 4 5 6 7	4 chunks	+2 lines, -10 lines	0 comments	Download
M	chrome/browser/google_apis/gdata_wapi_service_browsertest.cc	View	1 2 3 4 5	5 chunks	+6 lines, -6 lines	0 comments	Download
D	chrome/test/data/chromeos/drive/about.json	View	1	1 chunk	+0 lines, -251 lines	0 comments	Download
D	chrome/test/data/chromeos/drive/applist.json	View	1	1 chunk	+0 lines, -94 lines	0 comments	Download
D	chrome/test/data/chromeos/drive/changelist.json	View	1	1 chunk	+0 lines, -183 lines	0 comments	Download
D	chrome/test/data/chromeos/drive/filelist.json	View	1	1 chunk	+0 lines, -142 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/account_metadata.json	View		1 chunk	+0 lines, -382 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/basic_feed.json	View		1 chunk	+0 lines, -413 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/deleted_hosted_document_entry.json	View		1 chunk	+0 lines, -105 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/delta_dir_moved_from_root_to_directory.json	View		1 chunk	+0 lines, -230 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/delta_file_added_in_directory.json	View		1 chunk	+0 lines, -245 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/delta_file_added_in_new_but_deleted_directory.json	View		1 chunk	+0 lines, -252 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/delta_file_added_in_new_directory.json	View		1 chunk	+0 lines, -245 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/delta_file_added_in_root.json	View		1 chunk	+0 lines, -159 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/delta_file_deleted_in_directory.json	View		1 chunk	+0 lines, -168 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/delta_file_deleted_in_root.json	View		1 chunk	+0 lines, -162 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/delta_file_moved_from_directory_to_root.json	View		1 chunk	+0 lines, -230 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/delta_file_renamed_in_directory.json	View		1 chunk	+0 lines, -234 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/directory_entry.json	View		1 chunk	+0 lines, -88 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/directory_entry_atom.json	View		1 chunk	+0 lines, -86 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/directory_entry_atom2.json	View		1 chunk	+0 lines, -86 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/document_to_download.json	View		1 chunk	+0 lines, -99 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/empty_feed.json	View		1 chunk	+0 lines, -65 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/entry.xml	View		1 chunk	+0 lines, -1 line	0 comments	Download
D	chrome/test/data/chromeos/gdata/file_entry.json	View		1 chunk	+0 lines, -97 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/hosted_document_entry.json	View		1 chunk	+0 lines, -88 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/new_folder_entry.json	View		1 chunk	+0 lines, -89 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/remote_file_system_apitest_document_to_download.json	View		1 chunk	+0 lines, -100 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/remote_file_system_apitest_root_feed.json	View		1 chunk	+0 lines, -232 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/root_feed.json	View		1 chunk	+0 lines, -1100 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/search_result_feed.json	View		1 chunk	+0 lines, -243 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/search_result_with_new_entry_feed.json	View		1 chunk	+0 lines, -243 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/subdir_feed.json	View		1 chunk	+0 lines, -236 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/testfile.txt	View		1 chunk	+0 lines, -2 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/uploaded_document.json	View		1 chunk	+0 lines, -85 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/uploaded_file.json	View		1 chunk	+0 lines, -99 lines	0 comments	Download
A +	chrome/test/data/drive/about.json	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/drive/applist.json	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/drive/changelist.json	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/drive/filelist.json	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/gdata/account_metadata.json	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/gdata/basic_feed.json	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/gdata/deleted_hosted_document_entry.json	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/gdata/delta_dir_moved_from_root_to_directory.json	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/gdata/delta_file_added_in_directory.json	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/gdata/delta_file_added_in_new_but_deleted_directory.json	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/gdata/delta_file_added_in_new_directory.json	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/gdata/delta_file_added_in_root.json	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/gdata/delta_file_deleted_in_directory.json	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/gdata/delta_file_deleted_in_root.json	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/gdata/delta_file_moved_from_directory_to_root.json	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/gdata/delta_file_renamed_in_directory.json	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/gdata/directory_entry.json	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/gdata/directory_entry_atom.json	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/gdata/directory_entry_atom2.json	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/gdata/document_to_download.json	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/gdata/empty_feed.json	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/gdata/entry.xml	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/gdata/file_entry.json	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/gdata/hosted_document_entry.json	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/gdata/new_folder_entry.json	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/gdata/remote_file_system_apitest_document_to_download.json	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/gdata/remote_file_system_apitest_root_feed.json	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/gdata/root_feed.json	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/gdata/search_result_feed.json	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/gdata/search_result_with_new_entry_feed.json	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/gdata/subdir_feed.json	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/gdata/testfile.txt	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/gdata/uploaded_document.json	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/gdata/uploaded_file.json	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

satorux1

http://codereview.chromium.org/11293005/diff/10003/chrome/browser/google_apis/gdata_wapi_parser_unittest.cc File chrome/browser/google_apis/gdata_wapi_parser_unittest.cc (right): http://codereview.chromium.org/11293005/diff/10003/chrome/browser/google_apis/gdata_wapi_parser_unittest.cc#newcode34 chrome/browser/google_apis/gdata_wapi_parser_unittest.cc:34: path = path.AppendASCII("gdata").AppendASCII(filename.c_str()); Please use test_util::GetTestFilePath()

8 years, 1 month ago (2012-11-02 04:07:04 UTC) #2

tzik

Updated. Thanks! http://codereview.chromium.org/11293005/diff/10003/chrome/browser/google_apis/gdata_wapi_parser_unittest.cc File chrome/browser/google_apis/gdata_wapi_parser_unittest.cc (right): http://codereview.chromium.org/11293005/diff/10003/chrome/browser/google_apis/gdata_wapi_parser_unittest.cc#newcode34 chrome/browser/google_apis/gdata_wapi_parser_unittest.cc:34: path = path.AppendASCII("gdata").AppendASCII(filename.c_str()); On 2012/11/02 04:07:04, satorux1 ...

8 years, 1 month ago (2012-11-02 04:28:30 UTC) #3