Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: chrome/browser/google_apis/gdata_wapi_parser_unittest.cc

Issue 11293005: Move chrome/test/data/chromeos/gdata to chrome/test/data/gdata (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/google_apis/gdata_wapi_parser_unittest.cc
diff --git a/chrome/browser/google_apis/gdata_wapi_parser_unittest.cc b/chrome/browser/google_apis/gdata_wapi_parser_unittest.cc
index c428eb1cc0c8cd0b33ad6694cb677276d9645d8c..e2420b6599724a05ddf1fe34b3b594f89278142b 100644
--- a/chrome/browser/google_apis/gdata_wapi_parser_unittest.cc
+++ b/chrome/browser/google_apis/gdata_wapi_parser_unittest.cc
@@ -28,12 +28,8 @@ namespace google_apis {
class GDataWAPIParserTest : public testing::Test {
protected:
static DocumentEntry* LoadDocumentEntryFromXml(const std::string& filename) {
- FilePath path;
+ FilePath path = test_util::GetTestFilePath(filename);
std::string error;
- PathService::Get(chrome::DIR_TEST_DATA, &path);
- path = path.AppendASCII("chromeos")
- .AppendASCII("gdata")
- .AppendASCII(filename.c_str());
EXPECT_TRUE(file_util::PathExists(path)) <<
"Couldn't find " << path.value();
std::string contents;
@@ -54,9 +50,6 @@ class GDataWAPIParserTest : public testing::Test {
}
};
-// TODO(nhiroki): Make it possible to run these tests on any platforms after
-// moving json files to out of 'chromeos' directory (http://crbug.com/149788).
-#if defined(OS_CHROMEOS)
// Test document feed parsing.
TEST_F(GDataWAPIParserTest, DocumentFeedJsonParser) {
std::string error;
@@ -189,7 +182,7 @@ TEST_F(GDataWAPIParserTest, DocumentFeedJsonParser) {
// Test document feed parsing.
TEST_F(GDataWAPIParserTest, DocumentEntryXmlParser) {
- scoped_ptr<DocumentEntry> entry(LoadDocumentEntryFromXml("entry.xml"));
+ scoped_ptr<DocumentEntry> entry(LoadDocumentEntryFromXml("gdata/entry.xml"));
ASSERT_TRUE(entry.get());
EXPECT_EQ(ENTRY_KIND_FILE, entry->kind());
@@ -336,7 +329,6 @@ TEST_F(GDataWAPIParserTest, AccountMetadataFeedParser) {
EXPECT_EQ(1U, second_app->primary_extensions().size());
EXPECT_EQ(0U, second_app->secondary_extensions().size());
}
-#endif // OS_CHROMEOS
// Test file extension checking in DocumentEntry::HasDocumentExtension().
TEST_F(GDataWAPIParserTest, DocumentEntryHasDocumentExtension) {
« no previous file with comments | « chrome/browser/google_apis/gdata_test_util.cc ('k') | chrome/browser/google_apis/gdata_wapi_service_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698