Changes android.py to wait longer with --wait-for-debugger

Changes android.py to wait longer with --wait-for-debugger

Otherwise it exits before I've had a chance to attach the debugger.

BUG=none
TEST=none
R=msw@chromium.org

Committed: https://crrev.com/baef2353cc74d8ea2900d4328781e4ea062b63eb
Cr-Commit-Position: refs/heads/master@{#329864}

[msw, 2015-05-14 00:21:34]

lgtm with a quick q.

https://codereview.chromium.org/1129233007/diff/1/mojo/tools/mopy/android.py
File mojo/tools/mopy/android.py (right):

https://codereview.chromium.org/1129233007/diff/1/mojo/tools/mopy/android.py#...
mojo/tools/mopy/android.py:363: if '--wait-for-debugger' in arguments:
q: should we remove that switch from |arguments| after this?

[sky, 2015-05-14 16:07:14]

https://codereview.chromium.org/1129233007/diff/1/mojo/tools/mopy/android.py
File mojo/tools/mopy/android.py (right):

https://codereview.chromium.org/1129233007/diff/1/mojo/tools/mopy/android.py#...
mojo/tools/mopy/android.py:363: if '--wait-for-debugger' in arguments:
On 2015/05/14 00:21:33, msw wrote:
> q: should we remove that switch from |arguments| after this?

What do you mean?

[msw, 2015-05-14 16:52:14]

https://codereview.chromium.org/1129233007/diff/1/mojo/tools/mopy/android.py
File mojo/tools/mopy/android.py (right):

https://codereview.chromium.org/1129233007/diff/1/mojo/tools/mopy/android.py#...
mojo/tools/mopy/android.py:363: if '--wait-for-debugger' in arguments:
On 2015/05/14 16:07:14, sky wrote:
> On 2015/05/14 00:21:33, msw wrote:
> > q: should we remove that switch from |arguments| after this?
> 
> What do you mean?

I'm wondering if --wait-for-debugger should be passed through to the application
or not, it probably doesn't matter.

[sky, 2015-05-14 16:54:33]

https://codereview.chromium.org/1129233007/diff/1/mojo/tools/mopy/android.py
File mojo/tools/mopy/android.py (right):

https://codereview.chromium.org/1129233007/diff/1/mojo/tools/mopy/android.py#...
mojo/tools/mopy/android.py:363: if '--wait-for-debugger' in arguments:
On 2015/05/14 16:52:14, msw wrote:
> On 2015/05/14 16:07:14, sky wrote:
> > On 2015/05/14 00:21:33, msw wrote:
> > > q: should we remove that switch from |arguments| after this?
> > 
> > What do you mean?
> 
> I'm wondering if --wait-for-debugger should be passed through to the
application
> or not, it probably doesn't matter.

The shell definitely needs to see --wait-for-debugger, otherwise it's not going
to wait.

[msw, 2015-05-14 17:04:35]

https://codereview.chromium.org/1129233007/diff/1/mojo/tools/mopy/android.py
File mojo/tools/mopy/android.py (right):

https://codereview.chromium.org/1129233007/diff/1/mojo/tools/mopy/android.py#...
mojo/tools/mopy/android.py:363: if '--wait-for-debugger' in arguments:
On 2015/05/14 16:54:33, sky wrote:
> On 2015/05/14 16:52:14, msw wrote:
> > On 2015/05/14 16:07:14, sky wrote:
> > > On 2015/05/14 00:21:33, msw wrote:
> > > > q: should we remove that switch from |arguments| after this?
> > > 
> > > What do you mean?
> > 
> > I'm wondering if --wait-for-debugger should be passed through to the
> application
> > or not, it probably doesn't matter.
> 
> The shell definitely needs to see --wait-for-debugger, otherwise it's not
going
> to wait.

Woops, I guess it was a dumb question. I just didn't see our use of the literal
or kWaitForDebugger on codesearch.

[sky, 2015-05-14 17:07:09]

The CQ bit was checked by sky@chromium.org

[sky, 2015-05-14 17:07:21]

Ya, John went with a different name.

On Thu, May 14, 2015 at 10:04 AM,  <msw@chromium.org> wrote:
>
> https://codereview.chromium.org/1129233007/diff/1/mojo/tools/mopy/android.py
> File mojo/tools/mopy/android.py (right):
>
>
https://codereview.chromium.org/1129233007/diff/1/mojo/tools/mopy/android.py#...
> mojo/tools/mopy/android.py:363: if '--wait-for-debugger' in arguments:
> On 2015/05/14 16:54:33, sky wrote:
>>
>> On 2015/05/14 16:52:14, msw wrote:
>> > On 2015/05/14 16:07:14, sky wrote:
>> > > On 2015/05/14 00:21:33, msw wrote:
>> > > > q: should we remove that switch from |arguments| after this?
>> > >
>> > > What do you mean?
>> >
>> > I'm wondering if --wait-for-debugger should be passed through to the
>> application
>> > or not, it probably doesn't matter.
>
>
>> The shell definitely needs to see --wait-for-debugger, otherwise it's
>
> not going
>>
>> to wait.
>
>
> Woops, I guess it was a dumb question. I just didn't see our use of the
> literal or kWaitForDebugger on codesearch.
>
> https://codereview.chromium.org/1129233007/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2015-05-14 17:07:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1129233007/1

[commit-bot: I haz the power, 2015-05-14 17:15:36]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-05-14 17:16:28]

Patchset 1 (id:??) landed as
https://crrev.com/baef2353cc74d8ea2900d4328781e4ea062b63eb
Cr-Commit-Position: refs/heads/master@{#329864}