Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1446)

Unified Diff: mojo/tools/mopy/android.py

Issue 1129233007: Changes android.py to wait longer with --wait-for-debugger (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/tools/mopy/android.py
diff --git a/mojo/tools/mopy/android.py b/mojo/tools/mopy/android.py
index bc38c444a387ccee80b5241f2662a076d9247894..2354c8e5f9138fa1f63283ce97786cf21d4ecf0b 100644
--- a/mojo/tools/mopy/android.py
+++ b/mojo/tools/mopy/android.py
@@ -359,7 +359,11 @@ class AndroidShell(object):
subprocess.check_call(self._CreateADBCommand(
['shell', 'rm', '-f', STDOUT_PIPE]))
parameters.append('--fifo-path=%s' % STDOUT_PIPE)
- self._ReadFifo(STDOUT_PIPE, stdout, on_application_stop)
+ max_attempts = 5
+ if '--wait-for-debugger' in arguments:
msw 2015/05/14 00:21:33 q: should we remove that switch from |arguments| a
sky 2015/05/14 16:07:14 What do you mean?
msw 2015/05/14 16:52:14 I'm wondering if --wait-for-debugger should be pas
sky 2015/05/14 16:54:33 The shell definitely needs to see --wait-for-debug
msw 2015/05/14 17:04:35 Woops, I guess it was a dumb question. I just didn
+ max_attempts = 200
+ self._ReadFifo(STDOUT_PIPE, stdout, on_application_stop,
+ max_attempts=max_attempts)
# Extract map-origin arguments.
map_parameters, other_parameters = _Split(arguments, _IsMapOrigin)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698