Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1129103005: clang/win: Disable oilpan plugin on 64-bit builds again. (Closed)

Created:
5 years, 7 months ago by Nico
Modified:
5 years, 7 months ago
Reviewers:
hans
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Disable oilpan plugin on 64-bit builds again. This reverts https://codereview.chromium.org/1136943002 for 64-bit builds. There are many [blink-gc] warnings from the oilpan plugin at the moment, and the 64-bit bots build with warnings as errors. Disable the plugin on 64-bit builds to keep the bots green until they're fixed. BUG=486571, 467287 TBR=hans Committed: https://chromium.googlesource.com/chromium/src/+/18e6597a4d62570d8a6831c1521a551e7af9b077

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M build/common.gypi View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Nico
5 years, 7 months ago (2015-05-11 01:15:15 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/18e6597a4d62570d8a6831c1521a551e7af9b077 Cr-Commit-Position: refs/heads/master@{#329089}
5 years, 7 months ago (2015-05-11 01:22:20 UTC) #3
Nico
Committed patchset #1 (id:1) manually as 18e6597a4d62570d8a6831c1521a551e7af9b077 (presubmit successful).
5 years, 7 months ago (2015-05-11 01:22:37 UTC) #4
Nico
5 years, 7 months ago (2015-05-17 19:22:34 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1131333003/ by thakis@chromium.org.

The reason for reverting is: [blink-gc] warnings are fixed, we can turn this on
again.

Powered by Google App Engine
This is Rietveld 408576698