Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 1136943002: clang/win: Enable oilpan plugin on Windows. (Closed)

Created:
5 years, 7 months ago by Nico
Modified:
5 years, 7 months ago
Reviewers:
hans
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Enable oilpan plugin on Windows. I haven't tried building in this mode locally. I'll watch the bots and then revert this or fix issues as they come in (if any). Depends on the blink roll https://codereview.chromium.org/1140473002/ BUG=467287 TBR=hans@chromium.org Committed: https://crrev.com/9bf43610773b911b9dcd5f88311960a1fe56368a Cr-Commit-Position: refs/heads/master@{#329084}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
5 years, 7 months ago (2015-05-10 18:38:18 UTC) #1
Nico
Committed patchset #1 (id:1) to pending queue manually as eacff7665878978412df5c4ede352199960d5702 (presubmit successful).
5 years, 7 months ago (2015-05-10 22:03:17 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9bf43610773b911b9dcd5f88311960a1fe56368a Cr-Commit-Position: refs/heads/master@{#329084}
5 years, 7 months ago (2015-05-10 22:04:02 UTC) #3
hans
5 years, 7 months ago (2015-05-11 18:00:51 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698