chrome/browser/banners/app_banner_data_fetcher_unittest.cc - Issue 1129103003: Log messages regarding why app banners aren't displayed to the console

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/banners/app_banner_data_fetcher_unittest.cc

Issue 1129103003: Log messages regarding why app banners aren't displayed to the console (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Factoring out log messages into constants Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/banners/app_banner_data_fetcher.cc ('K') | « chrome/browser/banners/app_banner_data_fetcher.cc ('k') | chrome/browser/banners/app_banner_debug_log.h » ('j') | chrome/browser/banners/app_banner_debug_log.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/banners/app_banner_data_fetcher_unittest.cc

diff --git a/chrome/browser/banners/app_banner_data_fetcher_unittest.cc b/chrome/browser/banners/app_banner_data_fetcher_unittest.cc

index 2254130433b6c01e5066a7bc7d6489e2f5686cfa..3b68086d4912238f6ee11abb69a89a93ed16820b 100644

--- a/chrome/browser/banners/app_banner_data_fetcher_unittest.cc

+++ b/chrome/browser/banners/app_banner_data_fetcher_unittest.cc

@@ -33,7 +33,10 @@ class AppBannerDataFetcherUnitTest : public testing::Test {

}

static bool IsManifestValid(const content::Manifest& manifest) {

- return AppBannerDataFetcher::IsManifestValidForWebApp(manifest);

+ // The second argument is the web_contents pointer, which is used for

+ // developer debug logging to the console. The logging is skipped inside the

+ // method if a null web_contents pointer is provided, so this is safe.

+ return AppBannerDataFetcher::IsManifestValidForWebApp(manifest, nullptr);

}

};