Log messages regarding why app banners aren't displayed to the console

chrome/browser/banners/app_banner_data_fetcher.cc

Index: chrome/browser/banners/app_banner_data_fetcher.cc
diff --git a/chrome/browser/banners/app_banner_data_fetcher.cc b/chrome/browser/banners/app_banner_data_fetcher.cc
index 0fadc96e1887986533662a16c1fe3367d1c3195c..e5f3e91737cde497e58d6bc33dcc5af9003bd3d7 100644
--- a/chrome/browser/banners/app_banner_data_fetcher.cc
+++ b/chrome/browser/banners/app_banner_data_fetcher.cc
@@ -7,6 +7,7 @@
 #include "base/bind.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
+#include "chrome/browser/banners/app_banner_debug_log.h"
 #include "chrome/browser/banners/app_banner_metrics.h"
 #include "chrome/browser/banners/app_banner_settings_helper.h"
 #include "chrome/browser/bitmap_fetcher/bitmap_fetcher.h"
@@ -140,13 +141,15 @@ void AppBannerDataFetcher::OnBannerPromptReply(
     int request_id,
     blink::WebAppBannerPromptReply reply) {
   content::WebContents* web_contents = GetWebContents();
-  if (!is_active_ || !web_contents || request_id != event_request_id_) {
+  if (!CheckFetcherIsStillAlive(web_contents) ||
+      request_id != event_request_id_) {
     Cancel();
     return;
   }
 
   // The renderer might have requested the prompt to be canceled.
   if (reply == blink::WebAppBannerPromptReply::Cancel) {
+    OutputDeveloperNotShownMessage(web_contents, kRendererRequestCancel);
     Cancel();
     return;
   }
@@ -231,7 +234,11 @@ void AppBannerDataFetcher::RecordDidShowBanner(const std::string& event_name) {
 void AppBannerDataFetcher::OnDidGetManifest(
     const content::Manifest& manifest) {
   content::WebContents* web_contents = GetWebContents();
-  if (!is_active_ || !web_contents || manifest.IsEmpty()) {
+  if (!CheckFetcherIsStillAlive(web_contents)) {
+    Cancel();
+    return;
+  } else if (manifest.IsEmpty()) {

[benwells, 2015/05/13 02:55:20]

Nit: no else after return.

[dominickn (DO NOT USE), 2015/05/13 03:08:06]

Done.

+    OutputDeveloperNotShownMessage(web_contents, kManifestEmpty);
     Cancel();
     return;
   }
@@ -246,7 +253,7 @@ void AppBannerDataFetcher::OnDidGetManifest(
     }
   }
 
-  if (!IsManifestValidForWebApp(manifest)) {
+  if (!IsManifestValidForWebApp(manifest, web_contents)) {
     Cancel();
     return;
   }
@@ -274,7 +281,7 @@ void AppBannerDataFetcher::OnDidGetManifest(
 void AppBannerDataFetcher::OnDidCheckHasServiceWorker(
     bool has_service_worker) {
   content::WebContents* web_contents = GetWebContents();
-  if (!is_active_ || !web_contents) {
+  if (!CheckFetcherIsStillAlive(web_contents)) {
     Cancel();
     return;
   }
@@ -290,8 +297,10 @@ void AppBannerDataFetcher::OnDidCheckHasServiceWorker(
       FetchIcon(icon_url);
       return;
     }
+    OutputDeveloperNotShownMessage(web_contents, kCannotDetermineBestIcon);
   } else {
     TrackDisplayEvent(DISPLAY_EVENT_LACKS_SERVICE_WORKER);
+    OutputDeveloperNotShownMessage(web_contents, kNoMatchingServiceWorker);
   }
 
   Cancel();
@@ -307,13 +316,20 @@ void AppBannerDataFetcher::OnFetchComplete(const GURL& url,
 
 void AppBannerDataFetcher::ShowBanner(const SkBitmap* icon) {
   content::WebContents* web_contents = GetWebContents();
-  if (!is_active_ || !web_contents || !icon) {
+  if (!CheckFetcherIsStillAlive(web_contents)) {
+    Cancel();
+    return;
+  } else if (!icon) {

[benwells, 2015/05/13 02:55:20]

Nit: no else after return.

[dominickn (DO NOT USE), 2015/05/13 03:08:06]

Done.

+    OutputDeveloperNotShownMessage(web_contents, kNoIconAvailable);
     Cancel();
     return;
   }
 
   RecordCouldShowBanner();
   if (!CheckIfShouldShowBanner()) {
+    // At this point, the only possible case is that the banner has been added
+    // to the homescreen, given all of the other checks that have been made.
+    OutputDeveloperNotShownMessage(web_contents, kBannerAlreadyAdded);
     Cancel();
     return;
   }
@@ -345,17 +361,40 @@ bool AppBannerDataFetcher::CheckIfShouldShowBanner() {
       web_contents, validated_url_, GetAppIdentifier(), GetCurrentTime());
 }
 
+bool AppBannerDataFetcher::CheckFetcherIsStillAlive(
+    content::WebContents* web_contents) {
+  if (!is_active_) {
+    OutputDeveloperNotShownMessage(web_contents,
+                                   kUserNavigatedBeforeBannerShown);
+    return false;
+  }
+  if (!web_contents) {
+    return false; // We cannot show a message if web_contents is null
+  }
+  return true;
+}
+
 // static
 bool AppBannerDataFetcher::IsManifestValidForWebApp(
-    const content::Manifest& manifest) {
-  if (manifest.IsEmpty())
+    const content::Manifest& manifest,
+    content::WebContents* web_contents) {
+  if (manifest.IsEmpty()) {
+    OutputDeveloperNotShownMessage(web_contents, kManifestEmpty);
     return false;
-  if (!manifest.start_url.is_valid())
+  }
+  if (!manifest.start_url.is_valid()) {
+    OutputDeveloperNotShownMessage(web_contents, kStartURLNotValid);
     return false;
-  if (manifest.name.is_null() && manifest.short_name.is_null())
+  }
+  if (manifest.name.is_null() && manifest.short_name.is_null()) {
+    OutputDeveloperNotShownMessage(web_contents,
+                                   kManifestMissingNameOrShortName);
     return false;
-  if (!DoesManifestContainRequiredIcon(manifest))
+  }
+  if (!DoesManifestContainRequiredIcon(manifest)) {
+    OutputDeveloperNotShownMessage(web_contents, kManifestMissingSuitableIcon);
     return false;
+  }
   return true;
 }