Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Unified Diff: chrome/browser/banners/app_banner_data_fetcher_unittest.cc

Issue 1129103003: Log messages regarding why app banners aren't displayed to the console (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding a full stop to the end of a comment Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/banners/app_banner_data_fetcher.cc ('k') | chrome/browser/banners/app_banner_debug_log.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/banners/app_banner_data_fetcher_unittest.cc
diff --git a/chrome/browser/banners/app_banner_data_fetcher_unittest.cc b/chrome/browser/banners/app_banner_data_fetcher_unittest.cc
index 2254130433b6c01e5066a7bc7d6489e2f5686cfa..3b68086d4912238f6ee11abb69a89a93ed16820b 100644
--- a/chrome/browser/banners/app_banner_data_fetcher_unittest.cc
+++ b/chrome/browser/banners/app_banner_data_fetcher_unittest.cc
@@ -33,7 +33,10 @@ class AppBannerDataFetcherUnitTest : public testing::Test {
}
static bool IsManifestValid(const content::Manifest& manifest) {
- return AppBannerDataFetcher::IsManifestValidForWebApp(manifest);
+ // The second argument is the web_contents pointer, which is used for
+ // developer debug logging to the console. The logging is skipped inside the
+ // method if a null web_contents pointer is provided, so this is safe.
+ return AppBannerDataFetcher::IsManifestValidForWebApp(manifest, nullptr);
}
};
« no previous file with comments | « chrome/browser/banners/app_banner_data_fetcher.cc ('k') | chrome/browser/banners/app_banner_debug_log.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698