OLD | NEW |
1 // Copyright 2015 The Chromium Authors. All rights reserved. | 1 // Copyright 2015 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "chrome/browser/banners/app_banner_data_fetcher.h" | 5 #include "chrome/browser/banners/app_banner_data_fetcher.h" |
6 | 6 |
7 #include "base/strings/utf_string_conversions.h" | 7 #include "base/strings/utf_string_conversions.h" |
8 #include "testing/gtest/include/gtest/gtest.h" | 8 #include "testing/gtest/include/gtest/gtest.h" |
9 | 9 |
10 namespace banners { | 10 namespace banners { |
(...skipping 15 matching lines...) Expand all Loading... |
26 | 26 |
27 content::Manifest::Icon icon; | 27 content::Manifest::Icon icon; |
28 icon.type = ToNullableUTF16("image/png"); | 28 icon.type = ToNullableUTF16("image/png"); |
29 icon.sizes.push_back(gfx::Size(144, 144)); | 29 icon.sizes.push_back(gfx::Size(144, 144)); |
30 manifest.icons.push_back(icon); | 30 manifest.icons.push_back(icon); |
31 | 31 |
32 return manifest; | 32 return manifest; |
33 } | 33 } |
34 | 34 |
35 static bool IsManifestValid(const content::Manifest& manifest) { | 35 static bool IsManifestValid(const content::Manifest& manifest) { |
36 return AppBannerDataFetcher::IsManifestValidForWebApp(manifest); | 36 // The second argument is the web_contents pointer, which is used for |
| 37 // developer debug logging to the console. The logging is skipped inside the |
| 38 // method if a null web_contents pointer is provided, so this is safe. |
| 39 return AppBannerDataFetcher::IsManifestValidForWebApp(manifest, nullptr); |
37 } | 40 } |
38 }; | 41 }; |
39 | 42 |
40 TEST_F(AppBannerDataFetcherUnitTest, EmptyManifestIsInvalid) { | 43 TEST_F(AppBannerDataFetcherUnitTest, EmptyManifestIsInvalid) { |
41 content::Manifest manifest; | 44 content::Manifest manifest; |
42 EXPECT_FALSE(IsManifestValid(manifest)); | 45 EXPECT_FALSE(IsManifestValid(manifest)); |
43 } | 46 } |
44 | 47 |
45 TEST_F(AppBannerDataFetcherUnitTest, CheckMinimalValidManifest) { | 48 TEST_F(AppBannerDataFetcherUnitTest, CheckMinimalValidManifest) { |
46 content::Manifest manifest = GetValidManifest(); | 49 content::Manifest manifest = GetValidManifest(); |
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
98 // Non-square is okay. | 101 // Non-square is okay. |
99 manifest.icons[0].sizes[1] = gfx::Size(144, 200); | 102 manifest.icons[0].sizes[1] = gfx::Size(144, 200); |
100 EXPECT_TRUE(IsManifestValid(manifest)); | 103 EXPECT_TRUE(IsManifestValid(manifest)); |
101 | 104 |
102 // The representation of the keyword 'any' should be recognized. | 105 // The representation of the keyword 'any' should be recognized. |
103 manifest.icons[0].sizes[1] = gfx::Size(0, 0); | 106 manifest.icons[0].sizes[1] = gfx::Size(0, 0); |
104 EXPECT_TRUE(IsManifestValid(manifest)); | 107 EXPECT_TRUE(IsManifestValid(manifest)); |
105 } | 108 } |
106 | 109 |
107 } // namespace banners | 110 } // namespace banners |
OLD | NEW |