Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2193)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/chrome_browser.gypi

Issue 1129103003: Log messages regarding why app banners aren't displayed to the console (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing code health and style issues Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/banners/app_banner_data_fetcher.cc ('K') | « chrome/browser/banners/app_banner_manager.cc ('k') | chrome/common/render_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_browser.gypi
diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi
index 58ab61478405e1d5c9c0a3ed11815ca5c8cb6bbf..f259cfd627ba81df377c84d330a57cc0974b755d 100644
--- a/chrome/chrome_browser.gypi
+++ b/chrome/chrome_browser.gypi
@@ -216,6 +216,8 @@
'browser/banners/app_banner_metrics.h',
'browser/banners/app_banner_settings_helper.cc',
'browser/banners/app_banner_settings_helper.h',
+ 'browser/banners/app_banner_debug_log.cc',
Lei Zhang 2015/05/13 06:06:30 nit: alphabetical order please.
dominickn (DO NOT USE) 2015/05/13 06:13:47 Done.
+ 'browser/banners/app_banner_debug_log.h',
'browser/bitmap_fetcher/bitmap_fetcher.cc',
'browser/bitmap_fetcher/bitmap_fetcher.h',
'browser/bitmap_fetcher/bitmap_fetcher_delegate.h',
« chrome/browser/banners/app_banner_data_fetcher.cc ('K') | « chrome/browser/banners/app_banner_manager.cc ('k') | chrome/common/render_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698