Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Side by Side Diff: chrome/chrome_browser.gypi

Issue 1129103003: Log messages regarding why app banners aren't displayed to the console (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing code health and style issues Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2012 The Chromium Authors. All rights reserved. 1 # Copyright 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 # All .cc, .h, .m, and .mm files under browser except for: 7 # All .cc, .h, .m, and .mm files under browser except for:
8 # * tests and mocks. 8 # * tests and mocks.
9 # * code below browser/chromeos 9 # * code below browser/chromeos
10 # * code below browser/extensions 10 # * code below browser/extensions
(...skipping 198 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 'browser/autofill/validation_rules_storage_factory.cc', 209 'browser/autofill/validation_rules_storage_factory.cc',
210 'browser/autofill/validation_rules_storage_factory.h', 210 'browser/autofill/validation_rules_storage_factory.h',
211 'browser/banners/app_banner_data_fetcher.cc', 211 'browser/banners/app_banner_data_fetcher.cc',
212 'browser/banners/app_banner_data_fetcher.h', 212 'browser/banners/app_banner_data_fetcher.h',
213 'browser/banners/app_banner_manager.cc', 213 'browser/banners/app_banner_manager.cc',
214 'browser/banners/app_banner_manager.h', 214 'browser/banners/app_banner_manager.h',
215 'browser/banners/app_banner_metrics.cc', 215 'browser/banners/app_banner_metrics.cc',
216 'browser/banners/app_banner_metrics.h', 216 'browser/banners/app_banner_metrics.h',
217 'browser/banners/app_banner_settings_helper.cc', 217 'browser/banners/app_banner_settings_helper.cc',
218 'browser/banners/app_banner_settings_helper.h', 218 'browser/banners/app_banner_settings_helper.h',
219 'browser/banners/app_banner_debug_log.cc',
Lei Zhang 2015/05/13 06:06:30 nit: alphabetical order please.
dominickn (DO NOT USE) 2015/05/13 06:13:47 Done.
220 'browser/banners/app_banner_debug_log.h',
219 'browser/bitmap_fetcher/bitmap_fetcher.cc', 221 'browser/bitmap_fetcher/bitmap_fetcher.cc',
220 'browser/bitmap_fetcher/bitmap_fetcher.h', 222 'browser/bitmap_fetcher/bitmap_fetcher.h',
221 'browser/bitmap_fetcher/bitmap_fetcher_delegate.h', 223 'browser/bitmap_fetcher/bitmap_fetcher_delegate.h',
222 'browser/bitmap_fetcher/bitmap_fetcher_service.cc', 224 'browser/bitmap_fetcher/bitmap_fetcher_service.cc',
223 'browser/bitmap_fetcher/bitmap_fetcher_service.h', 225 'browser/bitmap_fetcher/bitmap_fetcher_service.h',
224 'browser/bitmap_fetcher/bitmap_fetcher_service_factory.cc', 226 'browser/bitmap_fetcher/bitmap_fetcher_service_factory.cc',
225 'browser/bitmap_fetcher/bitmap_fetcher_service_factory.h', 227 'browser/bitmap_fetcher/bitmap_fetcher_service_factory.h',
226 'browser/browser_about_handler.cc', 228 'browser/browser_about_handler.cc',
227 'browser/browser_about_handler.h', 229 'browser/browser_about_handler.h',
228 'browser/browser_shutdown.cc', 230 'browser/browser_shutdown.cc',
(...skipping 3636 matching lines...) Expand 10 before | Expand all | Expand 10 after
3865 'variables': { 3867 'variables': {
3866 'proto_in_dir': 'browser/sync_file_system/drive_backend', 3868 'proto_in_dir': 'browser/sync_file_system/drive_backend',
3867 'proto_out_dir': 'chrome/browser/sync_file_system/drive_backend', 3869 'proto_out_dir': 'chrome/browser/sync_file_system/drive_backend',
3868 }, 3870 },
3869 'includes': [ '../build/protoc.gypi' ] 3871 'includes': [ '../build/protoc.gypi' ]
3870 }, 3872 },
3871 ], 3873 ],
3872 },], 3874 },],
3873 ], 3875 ],
3874 } 3876 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698