Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/clang/plugins/tests/system/windows.h

Issue 1129093002: plugin: Do not warn on virtual/override stuff coming from macros in system headers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: actual change Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/clang/plugins/FindBadConstructsConsumer.cpp ('K') | « tools/clang/plugins/FindBadConstructsConsumer.cpp ('k') | tools/clang/plugins/tests/virtual_specifiers.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/tests/system/windows.h
diff --git a/tools/clang/plugins/tests/system/windows.h b/tools/clang/plugins/tests/system/windows.h
index f93d5e2db9f510fd16d389396b42a4818a4b418e..66e923de45d5b6bfd6ba9b20728ec8ec6b83349d 100644
--- a/tools/clang/plugins/tests/system/windows.h
+++ b/tools/clang/plugins/tests/system/windows.h
@@ -7,4 +7,9 @@
#define STDMETHOD(x) virtual void x
+#define END_COM_MAP() virtual void AddRef() = 0;
+
+#define SYSTEM_REDUNDANT1 virtual void NonVirtualFinal() final
+#define SYSTEM_REDUNDANT2 virtual void Virtual() override final
+
#endif // TOOLS_CLANG_PLUGINS_TESTS_SYSTEM_WINDOWS_H_
« tools/clang/plugins/FindBadConstructsConsumer.cpp ('K') | « tools/clang/plugins/FindBadConstructsConsumer.cpp ('k') | tools/clang/plugins/tests/virtual_specifiers.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698