tools/clang/plugins/tests/system/windows.h - Issue 1129093002: plugin: Do not warn on virtual/override stuff coming from macros in system headers.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/plugins/tests/system/windows.h

Issue 1129093002: plugin: Do not warn on virtual/override stuff coming from macros in system headers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: actual change Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« tools/clang/plugins/FindBadConstructsConsumer.cpp ('K') | « tools/clang/plugins/FindBadConstructsConsumer.cpp ('k') | tools/clang/plugins/tests/virtual_specifiers.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef TOOLS_CLANG_PLUGINS_TESTS_SYSTEM_WINDOWS_H_	5 #ifndef TOOLS_CLANG_PLUGINS_TESTS_SYSTEM_WINDOWS_H_

6 #define TOOLS_CLANG_PLUGINS_TESTS_SYSTEM_WINDOWS_H_	6 #define TOOLS_CLANG_PLUGINS_TESTS_SYSTEM_WINDOWS_H_

7	7

8 #define STDMETHOD(x) virtual void x	8 #define STDMETHOD(x) virtual void x

9	9

	10 #define END_COM_MAP() virtual void AddRef() = 0;

	11

	12 #define SYSTEM_REDUNDANT1 virtual void NonVirtualFinal() final

	13 #define SYSTEM_REDUNDANT2 virtual void Virtual() override final

	14

10 #endif // TOOLS_CLANG_PLUGINS_TESTS_SYSTEM_WINDOWS_H_	15 #endif // TOOLS_CLANG_PLUGINS_TESTS_SYSTEM_WINDOWS_H_

OLD	NEW