Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7133)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/chromedriver/chrome/web_view_impl.cc

Issue 1129083003: More base::Values-related bare pointer -> scoped_ptr conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/values_unittest.cc ('K') | « chrome/browser/ui/webui/options/core_options_handler.cc ('k') | chrome/test/chromedriver/commands_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome/web_view_impl.cc
diff --git a/chrome/test/chromedriver/chrome/web_view_impl.cc b/chrome/test/chromedriver/chrome/web_view_impl.cc
index 16e3df16b0d934e8f9b7353c85249bf8fa729b6f..c9cce52b38f2a88327f2c0bbfdb97ffaa4fc778d 100644
--- a/chrome/test/chromedriver/chrome/web_view_impl.cc
+++ b/chrome/test/chromedriver/chrome/web_view_impl.cc
@@ -722,7 +722,7 @@ Status EvaluateScriptAndGetValue(DevToolsClient* client,
return Status(kUnknownError, "Runtime.evaluate missing string 'type'");
if (type == "undefined") {
- result->reset(base::Value::CreateNullValue());
+ *result = base::Value::CreateNullValue();
} else {
base::Value* value;
if (!temp_result->Get("value", &value))
« base/values_unittest.cc ('K') | « chrome/browser/ui/webui/options/core_options_handler.cc ('k') | chrome/test/chromedriver/commands_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698