Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7445)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/webui/options/core_options_handler.cc

Issue 1129083003: More base::Values-related bare pointer -> scoped_ptr conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/values_unittest.cc ('K') | « chrome/browser/ui/webui/options/cookies_view_handler.cc ('k') | chrome/test/chromedriver/chrome/web_view_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/options/core_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/core_options_handler.cc b/chrome/browser/ui/webui/options/core_options_handler.cc
index 3ffe03457755544d452756992f37281e0a7e48b8..f1ca93addfd9e9ec42fe3ff68caa9a2ab9a19bc0 100644
--- a/chrome/browser/ui/webui/options/core_options_handler.cc
+++ b/chrome/browser/ui/webui/options/core_options_handler.cc
@@ -369,7 +369,7 @@ base::Value* CoreOptionsHandler::CreateValueForPref(
pref_service->FindPreference(pref_name.c_str());
if (!pref) {
NOTREACHED();
- return base::Value::CreateNullValue();
+ return base::Value::CreateNullValue().release();
}
const PrefService::Preference* controlling_pref =
pref_service->FindPreference(controlling_pref_name.c_str());
« base/values_unittest.cc ('K') | « chrome/browser/ui/webui/options/cookies_view_handler.cc ('k') | chrome/test/chromedriver/chrome/web_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698