More base::Values-related bare pointer -> scoped_ptr conversions

base/json/json_writer_unittest.cc

Index: base/json/json_writer_unittest.cc
diff --git a/base/json/json_writer_unittest.cc b/base/json/json_writer_unittest.cc
index ec60b5eeae768e65b738f29e77b3bba1c01eedbc..10f6cb54bada7b29b276f228b6b1676d21288f47 100644
--- a/base/json/json_writer_unittest.cc
+++ b/base/json/json_writer_unittest.cc
@@ -12,7 +12,7 @@ TEST(JSONWriterTest, BasicTypes) {
   std::string output_js;
 
   // Test null.
-  Value* root = Value::CreateNullValue();
+  Value* root = Value::CreateNullValue().release();

[danakj, 2015/05/08 18:07:25]

can you change |root| to a scoped_ptr?

[Evan Stade, 2015/05/08 18:32:09]

I could, but then I have to add like 12 .get()s and rewrite a bunch of operator=
lines. JSONWriter::Write should probably take a const ref, and we can stack
allocate all these values. So I don't think there's much benefit in updating
this code right now.

[danakj, 2015/05/08 18:33:41]

I think storing owned pointers in raw pointers is undesirable and we should use
a scoped_ptr for it to express ownership.

[Evan Stade, 2015/05/08 18:38:27]

We should not be using heap allocation in the first place. Updating this code
from one form of bad to another is not a good use of time when it should ideally
be changing to "good" soon.

   EXPECT_TRUE(JSONWriter::Write(root, &output_js));
   EXPECT_EQ("null", output_js);
   delete root;