Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Unified Diff: base/json/json_writer_unittest.cc

Issue 1129083003: More base::Values-related bare pointer -> scoped_ptr conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/json/json_writer_unittest.cc
diff --git a/base/json/json_writer_unittest.cc b/base/json/json_writer_unittest.cc
index ec60b5eeae768e65b738f29e77b3bba1c01eedbc..10f6cb54bada7b29b276f228b6b1676d21288f47 100644
--- a/base/json/json_writer_unittest.cc
+++ b/base/json/json_writer_unittest.cc
@@ -12,7 +12,7 @@ TEST(JSONWriterTest, BasicTypes) {
std::string output_js;
// Test null.
- Value* root = Value::CreateNullValue();
+ Value* root = Value::CreateNullValue().release();
danakj 2015/05/08 18:07:25 can you change |root| to a scoped_ptr?
Evan Stade 2015/05/08 18:32:09 I could, but then I have to add like 12 .get()s an
danakj 2015/05/08 18:33:41 I think storing owned pointers in raw pointers is
Evan Stade 2015/05/08 18:38:27 We should not be using heap allocation in the firs
EXPECT_TRUE(JSONWriter::Write(root, &output_js));
EXPECT_EQ("null", output_js);
delete root;

Powered by Google App Engine
This is Rietveld 408576698