OLD | NEW |
---|---|
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "base/json/json_writer.h" | 5 #include "base/json/json_writer.h" |
6 #include "base/values.h" | 6 #include "base/values.h" |
7 #include "testing/gtest/include/gtest/gtest.h" | 7 #include "testing/gtest/include/gtest/gtest.h" |
8 | 8 |
9 namespace base { | 9 namespace base { |
10 | 10 |
11 TEST(JSONWriterTest, BasicTypes) { | 11 TEST(JSONWriterTest, BasicTypes) { |
12 std::string output_js; | 12 std::string output_js; |
13 | 13 |
14 // Test null. | 14 // Test null. |
15 Value* root = Value::CreateNullValue(); | 15 Value* root = Value::CreateNullValue().release(); |
danakj
2015/05/08 18:07:25
can you change |root| to a scoped_ptr?
Evan Stade
2015/05/08 18:32:09
I could, but then I have to add like 12 .get()s an
danakj
2015/05/08 18:33:41
I think storing owned pointers in raw pointers is
Evan Stade
2015/05/08 18:38:27
We should not be using heap allocation in the firs
| |
16 EXPECT_TRUE(JSONWriter::Write(root, &output_js)); | 16 EXPECT_TRUE(JSONWriter::Write(root, &output_js)); |
17 EXPECT_EQ("null", output_js); | 17 EXPECT_EQ("null", output_js); |
18 delete root; | 18 delete root; |
19 | 19 |
20 // Test empty dict. | 20 // Test empty dict. |
21 root = new DictionaryValue; | 21 root = new DictionaryValue; |
22 EXPECT_TRUE(JSONWriter::Write(root, &output_js)); | 22 EXPECT_TRUE(JSONWriter::Write(root, &output_js)); |
23 EXPECT_EQ("{}", output_js); | 23 EXPECT_EQ("{}", output_js); |
24 delete root; | 24 delete root; |
25 | 25 |
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
167 // Test allowing a double with no fractional part to be written as an integer. | 167 // Test allowing a double with no fractional part to be written as an integer. |
168 FundamentalValue double_value(1e10); | 168 FundamentalValue double_value(1e10); |
169 EXPECT_TRUE(JSONWriter::WriteWithOptions( | 169 EXPECT_TRUE(JSONWriter::WriteWithOptions( |
170 &double_value, | 170 &double_value, |
171 JSONWriter::OPTIONS_OMIT_DOUBLE_TYPE_PRESERVATION, | 171 JSONWriter::OPTIONS_OMIT_DOUBLE_TYPE_PRESERVATION, |
172 &output_js)); | 172 &output_js)); |
173 EXPECT_EQ("10000000000", output_js); | 173 EXPECT_EQ("10000000000", output_js); |
174 } | 174 } |
175 | 175 |
176 } // namespace base | 176 } // namespace base |
OLD | NEW |