More base::Values-related bare pointer -> scoped_ptr conversions

base/json/json_writer_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/json/json_writer.h"
 #include "base/values.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace base {
 
 TEST(JSONWriterTest, BasicTypes) {
   std::string output_js;
 
   // Test null.
-  Value* root = Value::CreateNullValue();
+  Value* root = Value::CreateNullValue().release();

[danakj, 2015/05/08 18:07:25]

can you change |root| to a scoped_ptr?

[Evan Stade, 2015/05/08 18:32:09]

I could, but then I have to add like 12 .get()s and rewrite a bunch of operator=
lines. JSONWriter::Write should probably take a const ref, and we can stack
allocate all these values. So I don't think there's much benefit in updating
this code right now.

[danakj, 2015/05/08 18:33:41]

I think storing owned pointers in raw pointers is undesirable and we should use
a scoped_ptr for it to express ownership.

[Evan Stade, 2015/05/08 18:38:27]

We should not be using heap allocation in the first place. Updating this code
from one form of bad to another is not a good use of time when it should ideally
be changing to "good" soon.

   EXPECT_TRUE(JSONWriter::Write(root, &output_js));
   EXPECT_EQ("null", output_js);
   delete root;
 
   // Test empty dict.
   root = new DictionaryValue;
   EXPECT_TRUE(JSONWriter::Write(root, &output_js));
   EXPECT_EQ("{}", output_js);
   delete root;
 
@@ skipping 141 matching lines @@
   // Test allowing a double with no fractional part to be written as an integer.
   FundamentalValue double_value(1e10);
   EXPECT_TRUE(JSONWriter::WriteWithOptions(
       &double_value,
       JSONWriter::OPTIONS_OMIT_DOUBLE_TYPE_PRESERVATION,
       &output_js));
   EXPECT_EQ("10000000000", output_js);
 }
 
 }  // namespace base