Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1128933009: Show the cursor if it was hidden when starting partical screenshot. (Closed)

Created:
5 years, 7 months ago by oshima
Modified:
5 years, 7 months ago
Reviewers:
Jun Mukai
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show the cursor if it was hidden when starting partical screenshot. BUG=485649 TEST=PartialScreenShotTest.VisibilityTest R=mukai@chromium.org Committed: https://crrev.com/55dae7df996493abc81e6b9e435f69f1c23aa9f4 Cr-Commit-Position: refs/heads/master@{#330005}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M ash/utility/partial_screenshot_controller.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M ash/utility/partial_screenshot_controller_unittest.cc View 1 2 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128933009/1
5 years, 7 months ago (2015-05-14 22:22:30 UTC) #2
oshima
5 years, 7 months ago (2015-05-14 22:40:19 UTC) #3
Jun Mukai
https://codereview.chromium.org/1128933009/diff/1/ash/utility/partial_screenshot_controller.cc File ash/utility/partial_screenshot_controller.cc (right): https://codereview.chromium.org/1128933009/diff/1/ash/utility/partial_screenshot_controller.cc#newcode106 ash/utility/partial_screenshot_controller.cc:106: cursor_manager_->HideCursor(); Does it have to hide the cursor again? ...
5 years, 7 months ago (2015-05-14 22:49:10 UTC) #4
oshima
https://codereview.chromium.org/1128933009/diff/1/ash/utility/partial_screenshot_controller.cc File ash/utility/partial_screenshot_controller.cc (right): https://codereview.chromium.org/1128933009/diff/1/ash/utility/partial_screenshot_controller.cc#newcode106 ash/utility/partial_screenshot_controller.cc:106: cursor_manager_->HideCursor(); On 2015/05/14 22:49:10, Jun Mukai wrote: > Does ...
5 years, 7 months ago (2015-05-14 23:15:55 UTC) #5
Jun Mukai
lgtm
5 years, 7 months ago (2015-05-14 23:17:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128933009/20001
5 years, 7 months ago (2015-05-14 23:21:12 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/84106)
5 years, 7 months ago (2015-05-15 00:06:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128933009/40001
5 years, 7 months ago (2015-05-15 00:39:27 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-15 01:15:38 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 01:16:22 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/55dae7df996493abc81e6b9e435f69f1c23aa9f4
Cr-Commit-Position: refs/heads/master@{#330005}

Powered by Google App Engine
This is Rietveld 408576698