Show the cursor if it was hidden when starting partical screenshot.

ash/utility/partial_screenshot_controller.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/utility/partial_screenshot_controller.h"
 
 #include <cmath>
 
 #include "ash/screenshot_delegate.h"
 #include "ash/shell.h"
@@ skipping 77 matching lines @@
 class PartialScreenshotController::ScopedCursorSetter {
  public:
   ScopedCursorSetter(::wm::CursorManager* cursor_manager,
                      gfx::NativeCursor cursor)
       : cursor_manager_(nullptr) {
     if (cursor_manager->IsCursorLocked())
       return;
     gfx::NativeCursor original_cursor = cursor_manager->GetCursor();
     cursor_manager_ = cursor_manager;
     cursor_manager_->SetCursor(cursor);
+    bool was_visible = cursor_manager_->IsCursorVisible();
+    if (!was_visible)
+      cursor_manager_->ShowCursor();
     cursor_manager_->LockCursor();
-    // SetCursor does not make any effects at this point but it sets back to the
-    // original cursor when unlocked.
+    // SetCursor/HideCursor do not make any effects at this point
+    // but it sets back to the original cursor state when unlocked.
     cursor_manager_->SetCursor(original_cursor);
+    if (!was_visible)
+      cursor_manager_->HideCursor();

[Jun Mukai, 2015/05/14 22:49:10]

Does it have to hide the cursor again?
When cursor is invisible, and then partial screenshot is taken, then keeping it
visinble sounds natural to me, because user uses the mouse during the partial
screenshot session.

[oshima, 2015/05/14 23:15:55]

I was thinking "shift-ctrl-f5 then esc" scenario, but it's probably not
important. simplified the code.

   }
 
   ~ScopedCursorSetter() {
     if (cursor_manager_)
       cursor_manager_->UnlockCursor();
   }
 
  private:
   ::wm::CursorManager* cursor_manager_;
 
@@ skipping 144 matching lines @@
     return;
   Cancel();
 }
 
 void PartialScreenshotController::OnDisplayMetricsChanged(
     const gfx::Display& display,
     uint32_t changed_metrics) {
 }
 
 }  // namespace ash